Skip to content

Commit cfe1b6b

Browse files
committed
refactor: update prior-comment follow-up section in PR review documentation and remove obsolete skill
1 parent f2b7b65 commit cfe1b6b

2 files changed

Lines changed: 19 additions & 170 deletions

File tree

docs/COW_PR_REVIEW_SKILL.md

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Apply these as the default lens for every change. Pull in CoW-specific siblings
4646
Steps run in this order. `diff` mode skips PR-metadata steps; `pr-ci` swaps the report sink at the end.
4747

4848
1. Fetch PR metadata and linked issue(s) — [§2](#2-metadata-fetch). *(`pr-local` / `pr-ci` only.)*
49-
2. Triage prior review comments — [§2.5](#25-prior-comment-follow-up). *(`pr-local` / `pr-ci` only; further skip conditions in the sibling skill.)*
49+
2. Triage prior review comments — [§2.5](#25-prior-comment-follow-up). *(`pr-local` / `pr-ci` only; further skip conditions in §2.5.)*
5050
3. Classify diff paths and load conditional context — [§3](#3-conditional-context).
5151
4. Build a targeted codemap — [§4](#4-codemap-phase).
5252
5. Synthesize the context block — [§5](#5-context-synthesis).
@@ -97,15 +97,17 @@ If no linked issue is referenced, proceed without one. Do not manufacture one.
9797

9898
## 2.5 Prior-comment follow-up
9999

100-
*(Skip in `diff` mode — there is no PR yet.)*
100+
Skip when any of these holds — no output, the section is omitted from the report:
101101

102-
When a PR has prior inline review comments and the author has pushed new commits since, the reviewer's first question is *"did the author address what I asked last round?"* — not *"is this PR sound from scratch?"*. Surfacing that delta up front lets the reviewer resolve threads (or push back) without re-reading the whole conversation cold.
102+
- `mode == diff` (no PR yet).
103+
- No prior human inline reviews on the PR.
104+
- For every human reviewer, their latest review's `commit_id` already equals `<head_sha>` — no new commits since their last round.
103105

104-
Follow the [`pr-followup-triage`](skills/pr-followup-triage.md) skill with `<PR_NUMBER>`, `<owner>`, `<repo>` from [§2](#2-metadata-fetch), and `<head_sha>` = `commits[-1].oid` from the same metadata.
106+
Otherwise, for each prior inline comment from a human reviewer (use `gh api repos/<owner>/<repo>/pulls/<PR_NUMBER>/reviews` and `/comments`, GET only), surface one entry in the "Prior-comment follow-up" block ([§7](#7-report-templates)). Cite the new code at `<path>:<line>` that addresses it, the author's reply, or note that nothing has changed since `<prior_sha>`. Use stable identifiers `[A]`, `[B]`, ... so findings raised in this review can chain context with `Re: [A]`.
105107

106-
The skill's own [When to skip](skills/pr-followup-triage.md#when-to-skip) gates apply — most PRs (no prior reviews, or no commits since) will produce no output and the section is omitted from the report. Do not synthesise a follow-up block for a first-pass review.
108+
**Be conservative.** When the diff doesn't make the answer obvious, say so explicitly — false *"addressed"* tricks the reviewer into closing a thread that should stay open. Don't infer satisfaction from emoji reactions or short acknowledgements; the reviewer makes that call.
107109

108-
The output is the "Prior-comment follow-up" section in [§7](#7-report-templates). Findings raised in this PR may reference a prior comment by its bracketed identifier with `Re: [A]` to chain context.
110+
**Read-only.** No `gh pr review`, no `gh api` mutating verbs (`POST`/`PATCH`/`DELETE`), no comment-resolution endpoints. The reviewer resolves threads, not you.
109111

110112
---
111113

@@ -254,7 +256,17 @@ Codemap
254256
255257
Prior-comment follow-up — @<reviewer> at <prior_sha_short>
256258
───────────────────────────────────────────────────────────
257-
<from §2.5 — omit entirely if the sibling skill skipped>
259+
[A] <path>:<original_line>
260+
Asked: <≤12-word recap of what was asked>
261+
Status: ✓ Addressed | 💬 Discussion needed | ⏳ Pending
262+
⚠ Silently dropped | 🚫 Moot | ❓ Unclear
263+
Cite: <path>:<line at HEAD>, or "Author replied: ...", or
264+
"No change since <prior_sha_short>"
265+
266+
Sort what-needs-attention first: Discussion needed → Pending →
267+
Silently dropped → Unclear → Addressed → Moot.
268+
269+
(Omit the whole block if §2.5 skipped.)
258270
259271
───────────────────────────────────────────────────────────
260272
CONTEXT

docs/skills/pr-followup-triage.md

Lines changed: 0 additions & 163 deletions
This file was deleted.

0 commit comments

Comments
 (0)