Skip to content

Commit f59d54f

Browse files
committed
MB-65014: Reduce logging related to encryption key update
These extra log entries identified that it was in fact magma waiting for file IO causing SetActiveEncryptionKey command from ns_server timing out (reproduced locally with a ~3 minute wait time in magma) Change-Id: I1ff9094cbc70859e4a4fcc9e3b290933dc857a11 Reviewed-on: https://review.couchbase.org/c/kv_engine/+/224341 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Vesko Karaganev <vesko.karaganev@couchbase.com>
1 parent 316488d commit f59d54f

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

engines/ep/src/encryption_key_provider.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
#include "encryption_key_provider.h"
1212

13-
#include <bucket_logger.h>
14-
1513
cb::crypto::SharedEncryptionKey EncryptionKeyProvider::lookup(
1614
std::string_view id) const {
1715
if (id.empty()) {
@@ -21,15 +19,12 @@ cb::crypto::SharedEncryptionKey EncryptionKeyProvider::lookup(
2119
}
2220

2321
void EncryptionKeyProvider::setKeys(cb::crypto::KeyStore keys) {
24-
EP_LOG_INFO_RAW("Setting new encryption keys");
2522
keyStore = keys;
2623
listeners.withLock([&keys](auto& functions) {
2724
if (!functions.empty()) {
28-
EP_LOG_INFO_RAW("Notify kvstore of new encryption keys");
2925
for (const auto& function : functions) {
3026
function(keys);
3127
}
32-
EP_LOG_INFO_RAW("Done notifying kvstore of new encryption keys");
3328
}
3429
});
3530
}

0 commit comments

Comments
 (0)