RSCBC-250: Rename Disconnected error to ClusterDropped

Author: chvck

sdk/couchbase/src/clients/agent_provider.rs

@@ -92,7 +92,7 @@ impl CouchbaseAgentProvider {
     pub(crate) fn upgrade_agent(agent: Weak<Agent>) -> error::Result<Arc<Agent>> {
         match agent.upgrade() {
             Some(agent) => Ok(agent),
-            None => Err(error::Error::new(ErrorKind::Disconnected)),
+            None => Err(error::Error::new(ErrorKind::ClusterDropped)),
         }
     }
 }

sdk/couchbase/src/error.rs

@@ -171,7 +171,7 @@ impl StdError for Error {}
 pub enum ErrorKind {
     OtherFailure(String),
     ServerTimeout,
-    Disconnected,
+    ClusterDropped,
 
     // Shared Error Definitions RFC#58@16
     InvalidArgument(InvalidArgumentErrorKind),
@@ -258,8 +258,8 @@ impl Display for ErrorKind {
                     write!(f, "invalid argument: {msg}")
                 };
             }
-            ErrorKind::Disconnected => {
-                "the client is disconnected (have the parent bucket or cluster been dropped?)"
+            ErrorKind::ClusterDropped => {
+                "the client is disconnected (the cluster resource has been dropped)"
             }
             ErrorKind::ServiceNotAvailable(service) => {
                 return write!(f, "service not available: {service}");

sdk/couchbase/tests/connections.rs

@@ -60,7 +60,7 @@ fn test_collection_use_after_cluster_drop() {
                     Err(e) => e,
                 };
 
-                if &ErrorKind::Disconnected == err.kind() {
+                if &ErrorKind::ClusterDropped == err.kind() {
                     return Ok(Some(()));
                 }
 
@@ -101,7 +101,7 @@ fn test_collection_level_mgr_use_after_cluster_drop() {
                     Err(e) => e,
                 };
 
-                if &ErrorKind::Disconnected == err.kind() {
+                if &ErrorKind::ClusterDropped == err.kind() {
                     return Ok(Some(()));
                 }
 
@@ -137,7 +137,7 @@ fn test_scope_use_after_cluster_drop() {
                     Err(e) => e,
                 };
 
-                if &ErrorKind::Disconnected == err.kind() {
+                if &ErrorKind::ClusterDropped == err.kind() {
                     return Ok(Some(()));
                 }
 
@@ -175,7 +175,7 @@ fn test_scope_level_mgr_use_after_cluster_drop() {
                     Err(e) => e,
                 };
 
-                if &ErrorKind::Disconnected == err.kind() {
+                if &ErrorKind::ClusterDropped == err.kind() {
                     return Ok(Some(()));
                 }
 
@@ -211,7 +211,7 @@ fn test_bucket_level_mgr_use_after_cluster_drop() {
                     Err(e) => e,
                 };
 
-                if &ErrorKind::Disconnected == err.kind() {
+                if &ErrorKind::ClusterDropped == err.kind() {
                     return Ok(Some(()));
                 }
 
@@ -246,7 +246,7 @@ fn test_cluster_level_mgr_use_after_cluster_drop() {
                     Err(e) => e,
                 };
 
-                if &ErrorKind::Disconnected == err.kind() {
+                if &ErrorKind::ClusterDropped == err.kind() {
                     return Ok(Some(()));
                 }