Skip to content

cosmovisor: wrong check for upgrade height #26091

@0114kek

Description

@0114kek

In checkHeight function in scanner.go
It compares current height with upgrade height

// scanner.go line 166
currentHeight, err := fw.checkHeight()
	if (err != nil || currentHeight < info.Height) && !errors.Is(err, errUntestAble) {
		return false
	}

But when it reaches the upgrade height, currentHeight alwaysinfo.Heigh -1, leading to CheckUpdate function always return false. Because chain should be panicked in the process of block is finalized

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions