-
Notifications
You must be signed in to change notification settings - Fork 11
Review best way to construct delta field #8
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
There are currently different implementations for constructing delta field ~ data / randoms - 1 (smoothing of the data and randoms fields before computing delta, or after computing delta, threshold in number of randoms per cell), which follow the prescriptions used in original Bautista and White codes, e.g.:
pyrecon/pyrecon/iterative_fft_particle.py
Line 50 in 9549890
| def set_density_contrast(self, ran_min=0.01, smoothing_radius=15.): |
Line 192 in 9549890
| def set_density_contrast(self, ran_min=0.75, smoothing_radius=15., **kwargs): |
It'd be good to converge on a common prescription. Gaussian mocks (e.g. https://github.com/cosmodesi/pyrecon/blob/main/nb/e2e_examples.ipynb) with selection function in them may assist the choice.
WIthin current implementation, if randoms density is too small there will be a lot of delta points set to 0, hence highly inefficient reconstruction.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers