Skip to content

chore: bump cooklang-language-server to 0.2.3#361

Merged
dubadub merged 2 commits into
mainfrom
fix/bump-language-server-issue-10
Jun 26, 2026
Merged

chore: bump cooklang-language-server to 0.2.3#361
dubadub merged 2 commits into
mainfrom
fix/bump-language-server-issue-10

Conversation

@dubadub

@dubadub dubadub commented Jun 26, 2026

Copy link
Copy Markdown
Member

Bumps cooklang-language-server 0.2.1 → 0.2.3 to pick up the multi-word ingredient/cookware/timer parsing fix, so cook lsp correctly highlights and shows tooltips for names with spaces or punctuation (e.g. @heavy whipping cream{1%cup}).

Depends on cooklang/cooklang-language-server#8 being released to crates.io first (the Cargo.lock entry will resolve once 0.2.3 is published).

Relates to cooklang/CookVSCode#10

Picks up the multi-word ingredient/cookware/timer parsing fix so `cook lsp`
highlights and shows tooltips for names with spaces or punctuation.

Relates to cooklang/CookVSCode#10
@claude

claude Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review: chore: bump cooklang-language-server to 0.2.3

The change itself is correct and well-scoped — a one-line version bump with a clear rationale.

One concern before merging:

The PR description notes this depends on 0.2.3 being published to crates.io first. Until that happens, cargo build will fail with a "could not find package" error. Consider either:

  • Adding a note to block merge until the crate is confirmed live on crates.io, or
  • Merging only after confirming cargo update -p cooklang-language-server resolves to 0.2.3

Otherwise, the change is straightforward and the fix (multi-word ingredient/cookware/timer highlighting) is a worthwhile improvement. ✅

@claude

claude Bot commented Jun 26, 2026

Copy link
Copy Markdown

Code Review

This is a minimal dependency bump of cooklang-language-server from 0.2.1 → 0.2.3 across Cargo.toml and Cargo.lock. The crate's only public API used in this repo is Backend::new and the Backend struct (src/lsp.rs:3), which are stable across this patch range. No logic changes are introduced.


Findings

Stale PR descriptionCargo.lock already contains the 0.2.3 entry (with a valid 64-character SHA-256 checksum debf28fc...), which contradicts the description's note that "the Cargo.lock entry will resolve once 0.2.3 is published." Either 0.2.3 was already on crates.io when this was written, or the description wasn't updated after the lock file was committed. Worth correcting to avoid confusion for reviewers wondering whether CI will actually build.

Version skip (0.2.1 → 0.2.3) — 0.2.2 is absent from the lock file. Was 0.2.2 yanked, or was it simply never published? If yanked, it's worth a sentence in the PR body so reviewers aren't left wondering.


Everything else looks good

  • Cargo.lock checksum is the correct 64-character hex SHA-256 length.
  • The dependency tree entry is consistent (same cooklang, tower-lsp, etc. transitive deps).
  • The version constraint in Cargo.toml uses the standard caret form ("0.2.3" = >=0.2.3, <0.3), consistent with the rest of the file.
  • No security surface area is added; this crate is only invoked on the cook lsp path.

@dubadub dubadub merged commit 2994860 into main Jun 26, 2026
4 checks passed
@dubadub dubadub deleted the fix/bump-language-server-issue-10 branch June 26, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant