Bump go version to 1.26#1242
Closed
s1061123 wants to merge 7 commits intocontainernetworking:mainfrom
Closed
Conversation
Contributor
Author
|
@squeed PTAL? |
Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
s1061123
force-pushed
the
bump-go-version
branch
from
76c1d67 to
3ea7c3e
Compare
Contributor
Author
|
wait to merge #1238 that contains CI fix |
atombrella
reviewed
Mar 19, 2026
squeed
approved these changes
Mar 20, 2026
Member
|
@s1061123 looks reasonable; for some reason GitHub is complaining about conflicts? Not sure what's up with that. Feel free to merge yourself. |
Member
|
@s1061123 can you rebase and squash without a merge commit? |
Contributor
Author
|
Do that later and let you know later. |
The previous implementation filtered out routes without an explicit source address (route.Src == nil), which incorrectly removed routes added by IPAM plugins. IPAM plugins typically configure routes without setting a source address, causing those routes to be lost when the interface was moved to the VRF. The SCOPE_UNIVERSE filter already excludes local and connected routes that are automatically recreated by the kernel, so the additional route.Src filter was both unnecessary and harmful. Fixes containernetworking#1223 Signed-off-by: Marcelo Guerrero <marcegue@cisco.com>
The "test" prefix on hostVethName exceeds the 15-char Linux interface name limit (IFNAMSIZ), causing ERANGE instead of EEXIST. Shorten the prefix so the test exercises the intended error path. Signed-off-by: Marcelo Guerrero <marcegue@cisco.com>
Signed-off-by: sbiradar10 <sbiradar@redhat.com>
This PR includes the IP in the `AddrAdd` error message which could help debug better with any issues while adding the IP address to the bridge and improves the readability. Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
This reflects the version used in the GitHub workflows. Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
s1061123
force-pushed
the
bump-go-version
branch
from
8938a43 to
800cd9f
Compare
Contributor
Author
|
File another one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.