Skip to content

Commit a60c323

Browse files
committed
Fix unrecognized NO_LOG option
1 parent 83f9e08 commit a60c323

2 files changed

Lines changed: 48 additions & 1 deletion

File tree

src/Log/LogLevel.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public static function isValid($level): bool
3131
$level == self::ERROR ||
3232
$level == self::CRITICAL ||
3333
$level == self::ALERT ||
34-
$level == self::EMERGENCY;
34+
$level == self::EMERGENCY ||
35+
$level == self::NO_LOG;
3536
}
3637
}

tests/LoggerTest.php

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
namespace ConfigCat\Tests;
44

5+
use ConfigCat\ClientOptions;
6+
use ConfigCat\ConfigCatClient;
57
use ConfigCat\Hooks;
68
use ConfigCat\Log\InternalLogger;
79
use ConfigCat\Log\LogLevel;
@@ -443,6 +445,50 @@ public function testLoggerNoLog()
443445
$logger->warning("");
444446
}
445447

448+
public function testClientNoLog()
449+
{
450+
$mockLogger = $this->getMockBuilder(LoggerInterface::class)->getMock();
451+
452+
$client = new ConfigCatClient("not-existing", [
453+
ClientOptions::LOGGER => $mockLogger,
454+
ClientOptions::LOG_LEVEL => LogLevel::NO_LOG
455+
]);
456+
457+
$mockLogger
458+
->expects(self::never())
459+
->method("emergency");
460+
461+
$mockLogger
462+
->expects(self::never())
463+
->method("alert");
464+
465+
$mockLogger
466+
->expects(self::never())
467+
->method("critical");
468+
469+
$mockLogger
470+
->expects(self::never())
471+
->method("error");
472+
473+
$mockLogger
474+
->expects(self::never())
475+
->method("warning");
476+
477+
$mockLogger
478+
->expects(self::never())
479+
->method("notice");
480+
481+
$mockLogger
482+
->expects(self::never())
483+
->method("info");
484+
485+
$mockLogger
486+
->expects(self::never())
487+
->method("debug");
488+
489+
$client->getValue("fake", false);
490+
}
491+
446492
public function testLoggerBypassesLogWhenExceptionIsIgnored()
447493
{
448494
$mockLogger = $this->getMockBuilder(LoggerInterface::class)->getMock();

0 commit comments

Comments
 (0)