possible issue with HKG fuzzy firmware matching

[jyoung8607]

It's not clear to me why platform code fuzzy matching didn't work for the end user in #2974. May be room for improvement.

[jyoung8607]

For HKG, we don't allow fuzzy matching on fwdCamera unless it contains a six digit date code.

In this case:

b'\xf1\x00NQ5 FR_CMR AT USA LHD 1.00 1.01 99211-P1060 680',

On other cars with a valid date code on fwdCamera:

b'\xf1\x00JK1 MFC AT CAN LHD 1.00 1.02 99211-IY000 230627',

@sshane My inclination is to relax or even remove this check, but it was intentional on your part. Thoughts?

I was thinking of only blocking if len(expected_dates) and not len(found_dates). Or, we can allow 3 digit codes and treat them similarly, check to see if they're in the known range.

[adeebshihadeh]

Generally, the fuzzy fingerprinting we have so far is a sort of first pass, so I doubt much of this was intentional. If it was, the author should have left good comments!

[sshane]

There should be a comment mentioning we need to understand the other format when date code is not there