Set depth at rebuild!

[diesl]

I added Awesome Nested Set to an existing project where we have (scoped) records that are linked with parent_ids. After setting things up, I triggered a rebuild on the model. So far, so good, lft and rgt were set correctly.

However depth was set to 0 for every record. I also could not find a way to trigger a rebuild for depth (only). Do I miss something here?

My brute force workaround was to loop over all records and set depth to level which was resolved to the correct value.

See also similar tickets #314 and #116 that were closed as stale.

[parndt]

Thanks @diesl - can you please debug this a little on your local?
If you use bundle open awesome_nested_set to open the gem in your editor, and put debugging statements (like require 'pry';binding.pry or puts) inside the method compute_level then we can maybe see what the code is thinking about your table.

The relevant method is here

awesome_nested_set/lib/awesome_nested_set/model/relatable.rb

Lines 98 to 102 in 36ec2b0

	def compute_level
	node, nesting = determine_depth
	node == self ? ancestors.count : node.level + nesting
	end

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[diesl]

Not stale, I still need to debug

[mentalic]

This is still valid. We ended up doing Category.all.each do |c| c.save;end;0 after rebuild in order to recall the depth.

[diesl]

@parndt Finally I had some time for debugging.

I added a puts statement at the beginning of def compute_level. I did not get any output during Model.rebuild! and after checking the gem code, indeed I do not see any code triggering the computation of the depth during the rebuild:

awesome_nested_set/lib/awesome_nested_set/tree.rb

Lines 18 to 28 in 36ec2b0

	def rebuild!
	# Don't rebuild a valid tree.
	return true if model.valid?
	root_nodes.each do |root_node|
	# setup index for this scope
	indices[scope_for_rebuild.call(root_node)] ||= 0
	set_left_and_rights(root_node)
	reset_counter_cache(root_node)
	end
	end

I would expect that depth is set during rebuild. Do I have some misconception here?

---

Seems like you already discovered this behavior many years ago:

Yes, I've been noticing this too.. It seems the depth only gets built when you run save or move_to commands.

Originally posted by @parndt in #116 (comment)

[parndt]

@diesl thanks - I would expect if depth is being used that it gets set during rebuild! so I think that's how it should work (keen for this to be made to happen!)

[iainbeeston]

I just noticed this as well. I've also noticed that calling set_depth_for_self_and_descendants! on the root doesn't calculate the depth correctly either. At the moment my workaround is to call rebuild! followed by set_depth! on each node (which will only work for small numbers of nodes...)