Skip to content

Commit 88e7cd9

Browse files
committed
omits chrome-canary and chrome-beta from device emulation
1 parent 1d1efb4 commit 88e7cd9

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,14 @@ Telescope uses Playwright to control and manage individual browser engines. Tele
157157

158158
To install Microsoft Edge or Chrome Beta playwright requires root privileges and will not automatically install them, all you have to do that is to run `npx playwright install msedge chrome-beta` from the command line (and provide root password).
159159

160+
**Note:** Chrome Beta can occasionally result in hanging processes when emulating devices using Telescope. Device emulation is not supported for Chrome Beta instances.
161+
160162
### Chrome Canary
161163

162164
Chrome Canary must be manually installed, please download and install from: https://www.google.com/chrome/canary/
163165

166+
**Note:** Chrome Canary can occasionally result in hanging processes when emulating devices using Telescope. Device emulation is not supported for Chrome Canary instances.
167+
164168
### ffmpeg
165169

166170
Telescope uses `ffmpeg` to process the video and generate filmstrip images. You will need to have it installed on your machine.

__tests__/emulation.test.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,12 @@ describe.each(browsers)('Device Emulation Tests', browser => {
120120
describe.each(target_devices)(
121121
'launchTest executes and returns result object when emulating device: %s',
122122
device => {
123+
// device emulation causes timeouts in canary and beta for chrome,
124+
// telescope is not guarunteed to work in canary or beta
125+
if (browser === "canary" || browser === "chrome-beta") {
126+
console.info(`Skipping device emulation tests for browser: ${browser}`);
127+
return
128+
};
123129
let result: Awaited<ReturnType<typeof launchTest>>;
124130
beforeAll(async () => {
125131
let options = {
@@ -129,7 +135,7 @@ describe.each(browsers)('Device Emulation Tests', browser => {
129135
};
130136
const launchOptions = normalizeCLIConfig(options);
131137
result = await launchTest(launchOptions);
132-
}, 30000);
138+
}, 60000);
133139
test(`launchTest returns a result with success property for browser: ${browser}`, () => {
134140
expect(result).toHaveProperty('success');
135141
});

package-lock.json

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)