Skip to content

Commit 118667c

Browse files
Due to an abundance of caution, only set has_data based on dgram_emitted when gcongestion is enabled.
To limit functional changes due to fc172c8 to the BBR2 gcongestion algorithm
1 parent b5d2f40 commit 118667c

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

quiche/src/lib.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4784,6 +4784,12 @@ impl Connection {
47844784
aead,
47854785
)?;
47864786

4787+
let sent_pkt_has_data = if path.recovery.gcongestion_enabled() {
4788+
has_data || dgram_emitted
4789+
} else {
4790+
has_data
4791+
};
4792+
47874793
let sent_pkt = recovery::Sent {
47884794
pkt_num: pn,
47894795
frames,
@@ -4799,7 +4805,7 @@ impl Connection {
47994805
is_app_limited: false,
48004806
tx_in_flight: 0,
48014807
lost: 0,
4802-
has_data: has_data | dgram_emitted,
4808+
has_data: sent_pkt_has_data,
48034809
pmtud: pmtud_probe,
48044810
};
48054811

0 commit comments

Comments
 (0)