-
-
Notifications
You must be signed in to change notification settings - Fork 5
retype the filed from msat from String to int #74
Copy link
Copy link
Open
Labels
Hacktoberfestbug fixingc-ln-featureNew feature of c-lighthning to be supported in the libraryNew feature of c-lighthning to be supported in the librarygood first issueGood for newcomersGood for newcomersnew lightningd versionAdding support to the new version of lightningdAdding support to the new version of lightningdrefactoringrefactoring coderefactoring code
Milestone
Description
Metadata
Metadata
Assignees
Labels
Hacktoberfestbug fixingc-ln-featureNew feature of c-lighthning to be supported in the libraryNew feature of c-lighthning to be supported in the librarygood first issueGood for newcomersGood for newcomersnew lightningd versionAdding support to the new version of lightningdAdding support to the new version of lightningdrefactoringrefactoring coderefactoring code
The change implemented in the PR ElementsProject/lightning#5306 happens from the next release, so the solution is to break the type and move all
msatfiled from String to integer.We need to decide only if we want to support both or just the last version, commenting on the PR if you want discuss it before stat to working on it