Skip to content

Commit f8eb84a

Browse files
committed
Fix some style issues in Puppet manifests
These checks are performed on the Puppet Forge to give quality scores to modules, and are failing for the choria repositories: * The `ensure` parameter must be the first one in resource declaration; * Non-interpolated strings should be single, not double-quoted. A bunch of other issues are reported by puppet-lint, but as of today they do not seem to be part of the module score calculation, so in order to minimize changes, this commit do not address them. While these changes are gratuitous, they will allow the scoring of the modules to increase, giving users a more positive view of the care taken to maintain them.
1 parent 298c043 commit f8eb84a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

moduleroot/manifests/init.pp.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ class <%= choria_module_name %> (
2424
Hash $server_config = {},
2525
Boolean $client = $mcollective::client,
2626
Boolean $server = $mcollective::server,
27-
Enum["present", "absent"] $ensure = "present"
27+
Enum['present', 'absent'] $ensure = 'present'
2828
) {
2929
mcollective::module_plugin{$name:
30+
ensure => $ensure,
3031
config_name => $config_name,
3132
client_files => $client_files,
3233
server_files => $server_files,
@@ -48,6 +49,5 @@ class <%= choria_module_name %> (
4849
server_config => $server_config,
4950
client => $client,
5051
server => $server,
51-
ensure => $ensure
5252
}
5353
}

0 commit comments

Comments
 (0)