BUG:Not working after new metamodule changes

[fatalcoder524]

Module not working after migrating from old KSU APIs to new KSU supercall + meta modules.

Step to Reproduce
Steps to reproduce the behavior:

1. Install Latest developmental KernelSU-Next (Didn't test with other forks)
2. Install mountify / Magic mount (meta module) (not actually required)
3. Nuke YouTube.
4. Reboot

Expected behavior
Youtube must be nuked.

Environment (please complete the following information):

• Root Manager: KernelSU-Next
• Android Version 16
• Kernel Version 5.15.167

[chisewaguri]

@fatalcoder524 will look into this later

[becknik]

After updating KernelSU-Next to to v3.0.0, this module doesn't seem to work any more. I've even tried to use the build from this GH action run, but still no success.
Is this the reason for it?

I found the following in my exported KernelSU-Next logcat:

I app_nuker_debug: post-fs-data: mounting with mountify standalone script...
E overlay : case-insensitive capable filesystem on /mnt/vendor/app_nuker/product/app not supported
E overlay : case-insensitive capable filesystem on /mnt/vendor/app_nuker/product/priv-app not supported
E overlay : case-insensitive capable filesystem on /mnt/vendor/app_nuker/system_ext/priv-app not supported
E overlay : case-insensitive capable filesystem on /mnt/vendor/app_nuker/system/priv-app not supported

Then, when opening the webview:

E SuFilePathHandler: Error opening the requested path: default.png
E SuFilePathHandler: java.io.FileNotFoundException: No such file or directory: /data/adb/modules/system_app_nuker/webroot/default.png
E SuFilePathHandler: 	at q8.f.a(r8-map-id-d301c8c4a14e36f0c9ea81eae185ba18f65c23bad97a74b2786efe8cdd946912:153)
E SuFilePathHandler: 	at d5.r0.t(r8-map-id-d301c8c4a14e36f0c9ea81eae185ba18f65c23bad97a74b2786efe8cdd946912:2455)
E SuFilePathHandler: 	at o8.h.shouldInterceptRequest(r8-map-id-d301c8c4a14e36f0c9ea81eae185ba18f65c23bad97a74b2786efe8cdd946912:146)
E SuFilePathHandler: 	at WV.fg.a(chromium-TrichromeWebViewGoogle6432.aab-stable-749903433:100)
E SuFilePathHandler: 	at org.chromium.android_webview.ShouldInterceptRequestMediator.shouldInterceptRequestFromNative(chromium-TrichromeWebViewGoogle6432.aab-stable-749903433:18)

[chisewaguri]

I'll maybe look into this next week or so...

[fatalcoder524]

The module works fine when using mode 0 and mode 2 mounting.

I have tested and it works.. only issue is standalone mode.

[chisewaguri]

@fatalcoder524 noted, ill prolly look into it next week after exam period ends

update: sorry but turns out I still got final and clinical exams soo... ull prolly heard from me in late january

[acidcitrus]

The module works fine when using mode 0 and mode 2 mounting.

I have tested and it works.. only issue is standalone mode.

I can't get it to work with mode 2 on Mountify. Still not working with mode 0 on Magic-Mount-Rs or Hybrid Mount. I haven't tried OverlayFS since it's incompatible with NoneDisplayCutout.

[chisewaguri]

issues with mountify fixed on c27e66b
no issues with default mode

tested on kowsu lkm 32296

[acidcitrus]

Latest build works with Magic Mount Rs, but not Hybrid Mount even after toggling the magic mount/overlayfs setting in config with mode 1 standalone

[chisewaguri]

Latest build works with Magic Mount Rs, but not Hybrid Mount even after toggling the magic mount/overlayfs setting in config with mode 1 standalone

im not familiar with this metamodule ofs thing yet, ill look into it later ig...

[fatalcoder524]

Tested Latest CI with mountify. Takes mountify as default mode and works perfectly in terms of mounting and nuke.

[chisewaguri]

ill get into the overlayfs and hybrid metamodules later. for now, magic mount, mountify, and standalone without metamodule works fine

i really appreciate u guys' contribution

[fatalcoder524]

OP594DL1:/ # grep -E "500000|KSU|hymo" /proc/$(pidof com.android.nativetest)/mountinfo
500000 30678 0:139 / /system_ext/app rw,relatime master:5004 - overlay KSU ro,seclabel,lowerdir=/mnt/vendor/app_nuker/system_ext/app:/system_ext/app
500000 30678 0:143 / /system_ext/priv-app rw,relatime master:5005 - overlay KSU ro,seclabel,lowerdir=/mnt/vendor/app_nuker/system_ext/priv-app:/system_ext/priv-app
500000 30619 0:127 / /system/app rw,relatime master:5001 - overlay KSU ro,seclabel,lowerdir=/mnt/vendor/app_nuker/app:/system/app

The only drawback of SAN in mountify standalone mode is that we can't umount it. So detection exists. I'm using the Hymo meta module. It should be the same with Hybrid Mount, I think.

BTW, the mountify standalone script is not updated to support the ksud kernel umount, I think.

PS: Updating mountify.sh and setting mountify_kernel_umount=2 works. But still has Surrounding Suspicious detection, which is another matter.

More PS: I replaced whiteouts with blank files, and mode=0 works with Hymo. And now I have no detections.

[becknik]

More PS: I replaced whiteouts with blank files, and mode=0 works with Hymo. And now I have no detections.

Could you publish the patch for this?

[fatalcoder524]

More PS: I replaced whiteouts with blank files, and mode=0 works with Hymo. And now I have no detections.

Could you publish the patch for this?

Set mounting_mode in config.sh

And yes. After setting mode and updating script, re-nuke apps

#!/bin/sh
# nuke.sh
# this is part of system app nuker
# system app nuker whiteout module creator
# this is modified from mountify's whiteout creator
# No warranty.
PATH=/data/adb/ap/bin:/data/adb/ksu/bin:/data/adb/magisk:$PATH
MODDIR="/data/adb/modules/system_app_nuker"
MODULE_UPDATE_DIR="/data/adb/modules_update/system_app_nuker"
PERSIST_DIR="/data/adb/system_app_nuker"
APP_LIST="$PERSIST_DIR/app_list.json"
REMOVE_LIST="$PERSIST_DIR/nuke_list.json"

# import config
disable_only_mode="false"
mounting_mode=0
[ -f "$PERSIST_DIR/config.sh" ] && . $PERSIST_DIR/config.sh

# special dirs
# handle this properly so this script can be used standalone
# so yeah, symlinks.
IFS="
"
# vendor partitions
targets="
mi_ext
my_bigball
my_carrier
my_company
my_engineering
my_heytap
my_manifest
my_preload
my_product
my_region
my_reserve
my_stock"

# args handling
[ "$1" = "update" ] && update=true || update=false

# ----- functions -----

# whiteout creator
whiteout_create() {
    path="$1"
    echo "$path" | grep -q "^/system/" || path="/system$1"
    mkdir -p "$MODULE_UPDATE_DIR${path%/*}"
    chmod 755 "$MODULE_UPDATE_DIR${path%/*}"
    # not really required, mountify() does NOT even copy the attribute but ok
    if [ "$mounting_mode" != 0 ]; then
        busybox mknod "$MODULE_UPDATE_DIR$path" c 0 0
        busybox chcon --reference="/system" "$MODULE_UPDATE_DIR$path"
        busybox setfattr -n trusted.overlay.whiteout -v y "$MODULE_UPDATE_DIR$path"
    else
        touch "$MODULE_UPDATE_DIR$path"
        busybox chcon --reference="/system" "$MODULE_UPDATE_DIR$path"        
    fi
    chmod 644 "$MODULE_UPDATE_DIR$path"
}

# nuke app from REMOVE_LIST
nuke_system_apps() {
    total=$(grep -c '"package_name":' "$REMOVE_LIST")

    # first, remove any updates for the apps being nuked and disable them
    for package_name in $(grep -o "\"package_name\":.*" "$REMOVE_LIST" | awk -F"\"" '{print $4}'); do
        # check if it's a system app and has been updated
        if pm list packages -s | grep -qx "package:$package_name" && pm path "$package_name" | grep -q "/data/app"; then
            # uninstall system updates only if it's a system app that has been updated
            pm uninstall-system-updates "$package_name" >/dev/null 2>&1 || true
        fi
        pm disable "$package_name" >/dev/null 2>&1 || true
    done
    
    # whiteout creation
    if [ "$disable_only_mode" != "true" ]; then
        for apk_path in $(grep -E '"app_path":' "$REMOVE_LIST" | sed 's/.*"app_path": "\(.*\)",/\1/'); do
            # Create whiteout for apk_path
            whiteout_create "$(dirname $apk_path)" > /dev/null 2>&1
            ls "$MODULE_UPDATE_DIR$apk_path" 2>/dev/null
        done
    fi
    
    echo "[-] Nuking complete: $total apps processed"
    
    # brings back disabled apps
    local disabled_list=$(pm list packages -d)
    for package_name in $(grep -o "\"package_name\":.*" "$APP_LIST" | awk -F"\"" '{print $4}'); do
        if echo "$disabled_list" | grep -qx "package:$package_name"; then
            pm enable "$package_name" >/dev/null 2>&1 || true
        fi
    done
}

# this function install dummy.zip
# dummy.zip would call this script again
install_dummy() {
    if command -v apd >/dev/null 2>&1; then
        apd module install "$MODDIR/dummy.zip" && installed=true
    elif command -v ksud >/dev/null 2>&1; then
        ksud module install "$MODDIR/dummy.zip" && installed=true
    elif command -v magisk >/dev/null 2>&1; then
        magisk --install-module "$MODDIR/dummy.zip" && installed=true
    else
        echo "am I trippin or you are using some unknown root manager?"
        return 1
    fi

    # verify installation
    if [ "$installed" = true ]; then
        return 0
    else
        echo "dummy installation failed" >&2
        return 1
    fi
}

# ----- if called from webui -----

# lets have customize.sh of dummy.zip call us.
if [ ! "$DUMMYZIP" = "true" ] && [ ! "$update" = true ]; then
    # install dummy.zip
    install_dummy
    exit $?
fi

# ----- main script -----
# revamped routine
# here we copy over all the module files to modules_update folder.
# this is better than deleting system over and over
# also this way manager handles the update.
# this can avoid persistence issues too

# create folder if it doesnt exist and copy selinux context
[ ! -d "$MODULE_UPDATE_DIR" ] && mkdir -p "$MODULE_UPDATE_DIR"
busybox chcon --reference="/system" "$MODULE_UPDATE_DIR"

# if not update
if [ "$update" != true ]; then
    # copy module content, this also copy all scripts and module.prop
    # only copy content if module files was not copied yet
    # this ensure updated files are not overwritten
    if [ ! -f "$MODULE_UPDATE_DIR/nuke.sh" ]; then
        cp -Lrf "$MODDIR"/* "$MODULE_UPDATE_DIR"
    fi

    # flag module for update
    # check if module already flagged for update
    [ ! -f "$MODDIR/update" ] && touch "$MODDIR/update"
fi

# cleanup all old setup
for item in system system_ext vendor product update; do
    rm -rf "$MODULE_UPDATE_DIR/$item"
done

# skip app whiteout creation when remove list is empty
if grep -q '"package_name":' "$REMOVE_LIST"; then
    nuke_system_apps
fi

# handle raw whiteout
for line in $( sed '/#/d' "$PERSIST_DIR/raw_whiteouts.txt" ); do
	whiteout_create "$line" > /dev/null 2>&1 
	ls "$MODULE_UPDATE_DIR$line" 2>/dev/null
done

# handle vendor partitions
for part in $targets; do
    if [ -d "$MODULE_UPDATE_DIR/system/$part" ] && [ ! -L "/$part" ]; then
        echo "[-] Handling partition /$part"
        mv -f "$MODULE_UPDATE_DIR/system/$part" "$MODULE_UPDATE_DIR/$part"
        ln -sf "../$part" "$MODULE_UPDATE_DIR/system/$part"
    fi
done

# EOF