Merge pull request #3670 from chaoss/fix/move_name_keyerror

check for a lack of 200 status when looking up the moved repo name and log it

Author: sgoggins

augur/tasks/github/detect_move/core.py

@@ -59,7 +59,14 @@ def extract_owner_and_repo_from_endpoint(key_auth, url, logger):
     response_from_gh = hit_api(key_auth, url, logger)
 
     page_data = parse_json_response(logger, response_from_gh)
-
+    # Note: if parse_json_response fails, it will return a string, causing `in` to do a substring check.
+    # This may lead to a crash if the field is present but the parsing fails.
+    if response_from_gh.status_code != 200 or 'full_name' not in page_data:
+        logger.error(
+            f"Unexpected response fetching redirect target: status={response_from_gh.status_code}, "
+            f"url={url}, body={response_from_gh.text}"
+        )
+        raise Exception("Could not resolve owner/repo from redirect target due to missing data in the github response")
     full_repo_name = page_data['full_name']
 
     splits = full_repo_name.split('/')