BUG: Several bots have bad hardcoded default parameters

[gethvi]

1. File Output bot:

parameter file default is hardcoded to /opt/intelmq/var/lib/bots/file-output/events.txt (doesnt respect INTELMQ_PATHS_NO_OPT)

should be something like: VAR_STATE_PATH / {BOT-ID} / events.txt

2. Files Output bot:

tmp: str = "/opt/intelmq/var/lib/bots/files-output/tmp"
dir: str = "/opt/intelmq/var/lib/bots/files-output/incoming"

(doesnt respect INTELMQ_PATHS_NO_OPT and BOT ID)

This issue is Work In Progress, there might be more.

3. SQLOutput + SQLMixin + Bot class

SQLOutput has jsondict_as_string boolean parameter with default value True.

intelmq/intelmq/bots/outputs/sql/output.py

Line 32 in a0c0ce5

jsondict_as_string = True

SQLMixin has message_jsondict_as_string boolean parameter with default value True.

intelmq/intelmq/lib/mixins/sql.py

Lines 27 to 28 in a0c0ce5

	# overwrite the default value from the OutputBot
	message_jsondict_as_string = True

Bot class sets jsondict_as_string based on message_jsondict_as_string and defaults to False.

intelmq/intelmq/lib/bot.py

Line 1346 in a0c0ce5

self.jsondict_as_string: bool = getattr(self, "message_jsondict_as_string", False)

This is very messy.

[sebix]

Regarding point 3:

This is very messy.

Differing parameter names have to do with historical evolution and (backward) compatibility. We harmonized it already over the years, which was already substantial work, and this is where we are now. Further normalization is appreciated :)

[sebix]

I believe 1 and 2 are solved by #2606 and #2587