Dispatch Google Sign-In UI presentation to main thread#808
Merged
Conversation
robingenz
added
platform: ios
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures Google Sign-In’s iOS UI presentation is always performed on the main thread to prevent intermittent UIKit crashes during OAuth flow presentation.
Changes:
- Dispatches
GIDSignIn.sharedInstance.signIn(withPresenting:)toDispatchQueue.main.asyncin the iOS implementation. - Adds a Changesets patch entry for
@capawesome/capacitor-google-sign-in.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/google-sign-in/ios/Plugin/GoogleSignIn.swift | Wrapes the Google Sign-In presentation call in a main-thread dispatch to avoid off-main UIKit presentation crashes. |
| .changeset/forty-mangos-feel.md | Declares a patch release noting the iOS main-thread dispatch fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@capawesome/capacitor-age-signals
@capawesome-team/capacitor-android-battery-optimization
@capawesome/capacitor-android-dark-mode-support
@capawesome/capacitor-android-edge-to-edge-support
@capawesome-team/capacitor-android-foreground-service
@capawesome/capacitor-app-review
@capawesome/capacitor-app-shortcuts
@capawesome/capacitor-app-update
@capawesome/capacitor-apple-sign-in
@capawesome/capacitor-asset-manager
@capawesome/capacitor-background-task
@capawesome/capacitor-badge
@capawesome/capacitor-cloudinary
@capawesome-team/capacitor-datetime-picker
@capawesome-team/capacitor-file-opener
@capawesome/capacitor-file-picker
@capawesome/capacitor-google-sign-in
@capawesome/capacitor-libsql
@capawesome/capacitor-live-update
@capawesome/capacitor-managed-configurations
@capawesome/capacitor-photo-editor
@capawesome/capacitor-posthog
@capawesome/capacitor-realtimekit
@capawesome/capacitor-screen-orientation
@capawesome/capacitor-screenshot
@capawesome/capacitor-square-mobile-payments
@capawesome/capacitor-superwall
@capawesome/capacitor-torch
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GIDSignIn.sharedInstance.signIn(withPresenting:)calls inDispatchQueue.main.asyncto ensure theSFSafariViewControlleris presented on the main thread, fixing an intermittentNSInternalInconsistencyExceptioncrash on iOS.Close #807