feat: various rule enhancements and adjustments (#174)

* feat: fix #153

* fix: rule 010 and add tests

* fix: latinism rules level, efficacy, add tests

* fix: use EOL token

* feat: fix #148

* fix: #146, add tests, adjust level

* chore: fix file endings

* chore: adjust severity level of rule 008

Author: SecondSkoll

styles/Canonical/005-Industry-product-names.yml

@@ -2,7 +2,7 @@ extends: substitution
 message: "Use '%s' instead of '%s'"
 link: https://docs.ubuntu.com/styleguide/en/#other-commonly-referenced-products/projects
 ignorecase: true
-level: error
+level: warning
 scope:
   - sentence
   - list
@@ -20,7 +20,8 @@ swap:
   Mysql : 'MySQL' 
   docker : 'Docker' 
   KubeFlow : 'Kubeflow' 
-  Google cloud : 'Google Cloud Platform'
+  Google cloud platform : 'Google Cloud Platform'
+  Google cloud(?! platform) : 'Google Cloud Platform'
   Influxdb : 'InfluxDB' 
   mattermost : 'Mattermost'
 

styles/Canonical/007-Headings-sentence-case.yml

@@ -2,6 +2,6 @@ extends: capitalization
 # Fork of Google style guide rule
 message: "'%s' should use sentence-style capitalisation."
 link: "https://docs.ubuntu.com/styleguide/en/#sentence-case"
-level: error
+level: warning
 scope: heading
 match: $sentence

styles/Canonical/008-Headings-no-period.yml

@@ -4,12 +4,12 @@ extends: existence
 message: "Don't use end punctuation in headings."
 link: https://docs.ubuntu.com/styleguide/en#headings
 nonword: true
-level: warning
+level: suggestion
 scope: heading
 action:
   name: edit
   params:
     - remove
-    - '.'
+    - '[.!?,]'
 tokens:
-  - '[a-z0-9][.](?:\s|$)'
+  - '[.!?,](?:\s|$)'

styles/Canonical/010-Punctuation-double-spaces.yml

@@ -5,11 +5,10 @@ message: "'%s' should have one space."
 link: 
 level: warning
 scope:
-  - sentence
-  - list
+  - raw
 nonword: true
 tokens:
-  - '[a-z][.?!] {2,}[A-Z]'
+  - '[.?!] {2,}$'
 
 # Reasoning:
 # We appreciate that you may have been taught to put two spaces after a 

styles/Canonical/013-Spell-out-numbers-below-10.yml

@@ -7,7 +7,7 @@ scope:
   - sentence
   - table.header
   - table.cell
-level: warning
+level: suggestion
 swap:
   (?<![\-\.\,:\/*-+#]|Day )0(?![\-\.\,:\/*-+]): zero
   (?<![\-\.\,:\/*-+#]|Day )1(?![\-\.\,:\/*-+])(?! Jan(?!uary)?| Feb(?!ruary)?| Mar(?!ch)?| Apr(?!il)?| May| Jun(?:e)?| Jul(?:y)?| Aug(?:ust)?| Sep(?:tember)?| Oct(?:ober)?| Nov(?:ember)?| Dec(?:ember)?): one

styles/Canonical/014a-Numbers-greater-than-nine-should-be-in-numeric-form.yml

@@ -8,7 +8,7 @@ scope:
   - table.header
   - table.cell
 ignorecase: true
-level: warning
+level: suggestion
 tokens:
   - ten
   - eleven

styles/Canonical/014b-Numbers-with-five-or-more-digits-must-have-comma-separators.yml

@@ -8,6 +8,6 @@ scope:
   - table.header
   - table.cell
 ignorecase: true
-level: warning
+level: suggestion
 tokens:
   - ([\d]{5,})

styles/Canonical/016-No-inline-comments.yml

@@ -2,9 +2,9 @@ extends: existence
 message: "Avoid inline comments in code blocks."
 scope: raw
 nonword: true
-level: warning
+level: suggestion
 tokens:
-  - ^```[^\n\{\}]*\n(([^\n`][^\n#]*\n|\n))*([^\n#]+ +#.*\n)+([^\n`]*\n)*```
-  - ^```[^\n\{\}]*\n([^\n`][^\n]*\n|\n)*([^\n\/][^\n\/]+ +\/\/.*\n)+([^\n`]*\n)*```
-  - '\.\. (code-block|code|sourcecode)::.*\n( {3,}:\w+:\n)*(\s+.* +#.*\n)+'
-  - '\.\. (code-block|code|sourcecode)::.*\n( {3,}:\w+:\n)*(\s+.* +\/\/.*\n)+'
+  - ^```[^\n\{\}]*\n(([^\n`][^\n#]*\n|\n))*([^\n#]+ +#.*\n)+([^\n`]*\n)*```$
+  - ^```[^\n\{\}]*\n([^\n`][^\n]*\n|\n)*([^\n\/][^\n\/]+ +\/\/.*\n)+([^\n`]*\n)*```$
+  - '\.\. (?:code-block|code|sourcecode):: ?.*\n(?: {3,}:\w+:\n)*(?:\n| {3,}[^\n#]+\n)*( {3,}[^\n]*#[^\n]*\n)(?:\n| {3,}[^\n#]+\n)*'
+  - '\.\. (?:code-block|code|sourcecode):: ?.*\n(?: {3,}:\w+:\n)*(?:\n| {3,}[^\n\/\/]+\n)*( {3,}[^\n]*\/\/[^\n]*\n)(?:\n| {3,}[^\n\/\/]+\n)*'

styles/Canonical/019-no-google-drive-images.yml

@@ -4,7 +4,7 @@ extends: existence
 message: "Don't use images from Google Drive. Use the asset manager."
 scope: raw
 nonword: true
-level: warning
+level: error
 tokens:
   - '!\[[^\n]*\]\([\w\.:\/\-=\? \"]+(drive.google|drive.usercontent.google)[\w\.:\/\-=\? \"]+\)'
   - '<[\w\.:\/-=? "]+(drive.google|drive.usercontent.google)[\w\.:\/\-=? "]+>'

styles/Canonical/025a-latinisms-with-english-equivalents.yml

@@ -1,16 +1,13 @@
+# 025 - Latinisms that have English equivalents
+
 extends: substitution
 message: "Instead of '%[2]s', use %[1]s."
 link: https://docs.ubuntu.com/styleguide/en#latin-words-and-phrases
-level: error
-scope:
-  - sentence
-  - list
-  - heading
-  - table.header
-  - table.cell
+level: suggestion
+nonword: true
 ignorecase: true
-swap: # Multiple word terms need to use "this\\sword" to match properly
-  "a\\spriori": "'self-evident', 'presupposed', 'presumed', or 'assumed'"
+swap:
+  \ba\spriori\b: "'self-evident', 'presupposed', 'presumed', or 'assumed'"
   \bad\shoc\b: "'unscheduled', 'unexpected', 'improvised', 'temporary', or 'bespoke'"
   \bad\sinfinitum\b: "'and so on', 'to the fullest extent', or 'recursively'"
   \bcf\.?\b: "'refer to'"
@@ -24,7 +21,6 @@ swap: # Multiple word terms need to use "this\\sword" to match properly
   \b(?:id\sest\b|ie\b|i\.e\.(?!\w)|i\.e(?![\.\w])): "'that is' or 'in other words'"
   \bin\ssitu\b: "'in place'"
   \b(?:nota\sbene\b|nb\b|n\.b\.(?!\w)|n\.b(?![\.\w])): "'note', 'notice', 'observe', 'pay attention to', or 'keep your eye on'"
-  \bper\b: "'each', 'every', or 'according to'"
   \bper\sdiem\b: "'every day'"
   \bper\scapita\b: "'every/each person'"
   \bper\sse\b: "'necessarily' or 'intrinsically'"
@@ -34,6 +30,5 @@ swap: # Multiple word terms need to use "this\\sword" to match properly
   \bstatus\squo\b: "'state' or 'state of things'"
   \bverbatim\b: "'exact words', 'exactly'"
   \b(?:versus|vs\.(?!\w)|vs(?![\.\w])): "'compared to/with' or 'opposed to'"
-  \bvia\b: "'through', 'with', or 'using'"
   \bvice\sversa\b: "'the reverse' or 'the other way around'"
-  \b(?:viz\.(?!\w)|viz(?![\w\.])): "'specifically' or 'namely'"
+  \b(viz\.(?!\w)|viz(?![\w\.])): "'specifically' or 'namely'"