Skip to content

Commit a2e147e

Browse files
authored
Merge pull request #91 from mikemanger/https-urls
Use HTTPS for documentation and test fixture URLs
2 parents b480a84 + a2e4eb2 commit a2e147e

33 files changed

+123
-113
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Guidelines for contributing
22

3-
1. [Fork the repository](https://help.github.com/articles/fork-a-repo).
4-
2. [Create a topic branch](http://learn.github.com/p/branching.html).
3+
1. [Fork the repository](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo).
4+
2. [Create a topic branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches).
55
3. Make your changes, including tests for your changes which maintain [coverage](https://coveralls.io/r/campaignmonitor/createsend-python).
66
4. Ensure that all tests pass, by running `rake`.
77
5. It should go without saying, but do not increment the version number in your commits.
8-
6. [Submit a pull request](https://help.github.com/articles/using-pull-requests).
8+
6. [Submit a pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests).

HISTORY.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# createsend-python history
22

3+
## v9.1.3 - 4 Feb, 2025
4+
* Updated cacert.pem. From [#92](https://github.com/campaignmonitor/createsend-python/pull/92)
5+
* Updates various URLs to use HTTPS
6+
* Fixes some URLs in CONTRIBUTING.md
7+
* Use GH Workflow badge instead of inactive Travis one in documentation. From [#91](https://github.com/campaignmonitor/createsend-python/pull/91)
8+
9+
10+
## v9.1.2 - 29 Jan, 2025
11+
* This release updates the add() and update() methods in lib/subscriber.py, enabling users to add subscribers' mobile numbers along with their consent to receive SMS messages.
12+
* Updated subscriber.py within samples to showcase new use cases resulting from these updates. [PR](https://github.com/campaignmonitor/createsend-python/pull/90)
13+
314
## v9.0.2 - 23 Jan, 2025
415
* Improved error handling for 400 and 500 errors: Now displays error codes and error messages for better debugging.
516

@@ -172,7 +183,7 @@
172183

173184
## v3.1.0 - 15 Apr, 2013
174185

175-
* Added support for [single sign on](http://www.campaignmonitor.com/api/account/#single_sign_on) which allows initiation of external login sessions to Campaign Monitor.
186+
* Added support for [single sign on](https://www.campaignmonitor.com/api/account/#single_sign_on) which allows initiation of external login sessions to Campaign Monitor.
176187

177188
## v3.0.0 - 25 Mar, 2013
178189

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# createsend
22

3-
A Python library which implements the complete functionality of the [Campaign Monitor API](http://www.campaignmonitor.com/api/). Requires Python 3.8 or above.
3+
A Python library which implements the complete functionality of the [Campaign Monitor API](https://www.campaignmonitor.com/api/). Requires Python 3.8 or above.
44

55
## Installation
66

@@ -14,9 +14,9 @@ The Campaign Monitor API supports authentication using either OAuth or an API ke
1414

1515
### Using OAuth
1616

17-
Depending on the environment you are developing in, you may wish to use a Python OAuth library to get access tokens for your users. If you use [Flask](http://flask.pocoo.org/), you may like to refer to this [example application](https://gist.github.com/jdennes/4754097), which uses the [Flask-OAuth](http://pythonhosted.org/Flask-OAuth/) package to authenticate.
17+
Depending on the environment you are developing in, you may wish to use a Python OAuth library to get access tokens for your users. If you use [Flask](https://flask.palletsprojects.com/en/stable/), you may like to refer to this [example application](https://gist.github.com/jdennes/4754097), which uses the [Flask-OAuth](https://pythonhosted.org/Flask-OAuth/) package to authenticate.
1818

19-
If you don't use an OAuth library, you will need to manually get access tokens for your users by following the instructions included in the Campaign Monitor API [documentation](http://www.campaignmonitor.com/api/getting-started/#authenticating_with_oauth). This package provides functionality to help you do this, as described below. There's also another Flask [example application](https://gist.github.com/jdennes/4761254) you may wish to reference, which doesn't depend on any OAuth libraries.
19+
If you don't use an OAuth library, you will need to manually get access tokens for your users by following the instructions included in the Campaign Monitor API [documentation](https://www.campaignmonitor.com/api/v3-3/getting-started/#authentication). This package provides functionality to help you do this, as described below. There's also another Flask [example application](https://gist.github.com/jdennes/4761254) you may wish to reference, which doesn't depend on any OAuth libraries.
2020

2121
The first thing your application should do is redirect your user to the Campaign Monitor authorization URL where they will have the opportunity to approve your application to access their Campaign Monitor account. You can get this authorization URL by using the `authorize_url()` function, like so:
2222

@@ -204,7 +204,7 @@ For example, if you wanted to find out how to call the `Subscriber.add()` method
204204
```python
205205
def test_add_with_custom_fields(self):
206206
self.subscriber.stub_request("subscribers/%s.json" % self.list_id, "add_subscriber.json")
207-
custom_fields = [ { "Key": 'website', "Value": 'http://example.com/' } ]
207+
custom_fields = [ { "Key": 'website', "Value": 'https://example.com/' } ]
208208
email_address = self.subscriber.add(self.list_id, "subscriber@example.com", "Subscriber", custom_fields, True)
209209
self.assertEqual(email_address, "subscriber@example.com")
210210
```
@@ -247,7 +247,6 @@ Please check the [instructions for releasing](https://github.com/campaignmonitor
247247

248248
## This stuff should be green
249249

250-
[![Build Status](https://secure.travis-ci.org/campaignmonitor/createsend-python.png)][travis] [![Coverage Status](https://coveralls.io/repos/campaignmonitor/createsend-python/badge.png?branch=master)][coveralls]
250+
[![Python tests](https://github.com/campaignmonitor/createsend-python/actions/workflows/tests.yml/badge.svg)](https://github.com/campaignmonitor/createsend-python/actions/workflows/tests.yml) [![Coverage Status](https://coveralls.io/repos/campaignmonitor/createsend-python/badge.png?branch=master)][coveralls]
251251

252-
[travis]: http://travis-ci.org/campaignmonitor/createsend-python
253252
[coveralls]: https://coveralls.io/r/campaignmonitor/createsend-python

RELEASE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ pip install setuptools
1414

1515
## Prepare the release
1616

17-
- Increment `version` in the `setup.py` file, ensuring that you use [Semantic Versioning](http://semver.org/).
17+
- Increment `version` in the `setup.py` file, ensuring that you use [Semantic Versioning](https://semver.org/).
1818
- Add an entry to `HISTORY.md` which clearly explains the new release.
1919
- Commit your changes:
2020

@@ -34,7 +34,7 @@ pip install setuptools
3434
git push origin master --tags
3535
```
3636

37-
- Ensure that all [tests](https://travis-ci.org/campaignmonitor/createsend-python) pass, and that [coverage](https://coveralls.io/r/campaignmonitor/createsend-python) is maintained or improved.
37+
- Ensure that all [tests](https://github.com/campaignmonitor/createsend-python/actions/workflows/tests.yml) pass, and that [coverage](https://coveralls.io/r/campaignmonitor/createsend-python) is maintained or improved.
3838

3939
- Add a new [GitHub Release](https://github.com/campaignmonitor/createsend-python/releases) using the newly created tag.
4040

lib/createsend/createsend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ def external_session_url(self, email, chrome, url, integrator_id, client_id):
312312
"""
313313
Get a URL which initiates a new external session for the user with the
314314
given email.
315-
Full details: http://www.campaignmonitor.com/api/account/#single_sign_on
315+
Full details: https://www.campaignmonitor.com/api/account/#single_sign_on
316316
317317
:param email: String The representing the email address of the
318318
Campaign Monitor user for whom the login session should be created.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
description="A library which implements the complete functionality of the Campaign Monitor API.",
77
author='Campaign Monitor',
88
author_email='support@campaignmonitor.com',
9-
url="http://campaignmonitor.github.io/createsend-python/",
9+
url="https://campaignmonitor.github.io/createsend-python/",
1010
license="MIT",
1111
keywords="createsend campaign monitor email",
1212
packages=find_packages('lib'),

test/fixtures/active_subscribers.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"CustomFields": [
1010
{
1111
"Key": "website",
12-
"Value": "http://example.com"
12+
"Value": "https://example.com"
1313
},
1414
{
1515
"Key": "multi select field",
@@ -39,7 +39,7 @@
3939
"CustomFields": [
4040
{
4141
"Key": "website",
42-
"Value": "http://subdomain.example.com"
42+
"Value": "https://subdomain.example.com"
4343
}
4444
],
4545
"ReadsEmailWith": "Gmail"
@@ -53,7 +53,7 @@
5353
"CustomFields": [
5454
{
5555
"Key": "website",
56-
"Value": "http://subdomain.example.com"
56+
"Value": "https://subdomain.example.com"
5757
}
5858
],
5959
"ReadsEmailWith": ""

test/fixtures/active_subscribers_with_tracking_preference.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"CustomFields": [
1010
{
1111
"Key": "website",
12-
"Value": "http://example.com"
12+
"Value": "https://example.com"
1313
},
1414
{
1515
"Key": "multi select field",
@@ -40,7 +40,7 @@
4040
"CustomFields": [
4141
{
4242
"Key": "website",
43-
"Value": "http://subdomain.example.com"
43+
"Value": "https://subdomain.example.com"
4444
}
4545
],
4646
"ReadsEmailWith": "Gmail",
@@ -55,7 +55,7 @@
5555
"CustomFields": [
5656
{
5757
"Key": "website",
58-
"Value": "http://subdomain.example.com"
58+
"Value": "https://subdomain.example.com"
5959
}
6060
],
6161
"ReadsEmailWith": "",

test/fixtures/campaign_clicks.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"Results": [
33
{
44
"EmailAddress": "subs+6576576576@example.com",
5-
"URL": "http://video.google.com.au/?hl=en&tab=wv",
5+
"URL": "https://video.google.com.au/?hl=en&tab=wv",
66
"ListID": "512a3bc577a58fdf689c654329b50fa0",
77
"Date": "2010-10-11 08:29:00",
88
"IPAddress": "192.168.126.87",
@@ -15,7 +15,7 @@
1515
},
1616
{
1717
"EmailAddress": "subs+6576576576@example.com",
18-
"URL": "http://mail.google.com/mail/?hl=en&tab=wm",
18+
"URL": "https://mail.google.com/mail/?hl=en&tab=wm",
1919
"ListID": "512a3bc577a58fdf689c654329b50fa0",
2020
"Date": "2010-10-11 08:29:00",
2121
"IPAddress": "192.168.126.87",
@@ -28,7 +28,7 @@
2828
},
2929
{
3030
"EmailAddress": "subs+6576576576@example.com",
31-
"URL": "http://mail.google.com/mail/?hl=en&tab=wm",
31+
"URL": "https://mail.google.com/mail/?hl=en&tab=wm",
3232
"ListID": "512a3bc577a58fdf689c654329b50fa0",
3333
"Date": "2010-10-06 17:24:00",
3434
"IPAddress": "192.168.126.87",

test/fixtures/campaign_summary.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"Mentions": 23,
1010
"Forwards": 11,
1111
"Likes": 32,
12-
"WebVersionURL": "http://createsend.com/t/r-3A433FC72FFE3B8B",
13-
"WebVersionTextURL": "http://createsend.com/t/r-3A433FC72FFE3B8B/t",
14-
"WorldviewURL": "http://client.createsend.com/reports/wv/r/3A433FC72FFE3B8B",
12+
"WebVersionURL": "https://createsend.com/t/r-3A433FC72FFE3B8B",
13+
"WebVersionTextURL": "https://createsend.com/t/r-3A433FC72FFE3B8B/t",
14+
"WorldviewURL": "https://client.createsend.com/reports/wv/r/3A433FC72FFE3B8B",
1515
"SpamComplaints": 23
1616
}

0 commit comments

Comments
 (0)