fix test

Author: vikonix

quasardb/arrow_batch_push.cpp

@@ -162,11 +162,10 @@ void exp_batch_push_arrow_with_options(handle_ptr handle,
     std::vector<qdb_ts_range_t> truncate_ranges;
     qdb_ts_range_t * range_ptr = nullptr;
 
-
     if (options.mode == qdb_exp_batch_push_truncate)
         [[unlikely]] // Unlikely because truncate isn't used much
     {
-        if (args.contains("range"))
+        if (args.contains(detail::batch_truncate_ranges::kw_range))
         {
             truncate_ranges = detail::batch_truncate_ranges::from_kwargs(args);
             range_ptr       = truncate_ranges.data();
@@ -180,6 +179,9 @@ void exp_batch_push_arrow_with_options(handle_ptr handle,
     arrow_batch batch{reader};
     auto c_batch = batch.build(table_name, dedup, range_ptr, truncate_ranges.size());
 
+    qdb::logger logger("quasardb.batch_push_arrow");
+    logger.debug("Pushing Arrow stream in %s using %s push mode", table_name,
+        detail::batch_push_mode::to_string(options.mode));
     qdb_error_t err{qdb_e_ok};
     {
         // Make sure to measure the time it takes to do the actual push.
@@ -190,7 +192,6 @@ void exp_batch_push_arrow_with_options(handle_ptr handle,
         err = qdb_exp_batch_push_arrow_with_options(*handle, &options, &c_batch, nullptr, 1u);
     }
 
-    qdb::logger logger("quasardb.batch_push_arrow");
     auto retry_options = detail::retry_options::from_kwargs(args);
     if (retry_options.should_retry(err))
         [[unlikely]] // Unlikely, because err is most likely to be qdb_e_ok

tests/test_pandas.py

@@ -308,12 +308,26 @@ def test_write_dataframe_push_fast(qdbpd_write_fn, qdbd_connection, df_with_tabl
 def test_write_dataframe_push_truncate(qdbpd_write_fn, qdbd_connection, df_with_table):
     (_, _, df1, table) = df_with_table
 
+    # For Arrow Push we need to have the truncate range
+    step = df1.index[1] - df1.index[0]
+    start = np.datetime64(df1.index[0].to_datetime64(), "ns")
+    end = np.datetime64((df1.index[-1] + step).to_datetime64(), "ns")
+    ranges = (start, end)
+
     # Ensures that we can do a full-circle write and read of a dataframe
     qdbpd_write_fn(
-        df1, qdbd_connection, table, push_mode=quasardb.WriterPushMode.Truncate
+        df1,
+        qdbd_connection,
+        table,
+        push_mode=quasardb.WriterPushMode.Truncate,
+        range=ranges,
     )
     qdbpd_write_fn(
-        df1, qdbd_connection, table, push_mode=quasardb.WriterPushMode.Truncate
+        df1,
+        qdbd_connection,
+        table,
+        push_mode=quasardb.WriterPushMode.Truncate,
+        range=ranges,
     )
 
     df2 = qdbpd.read_dataframe(qdbd_connection, table)
@@ -577,7 +591,11 @@ def test_push_mode(qdbpd_write_fn, df_with_table, push_mode, qdbd_connection, ca
         kwargs["_async"] = True
 
     caplog.clear()
-    caplog.set_level(logging.DEBUG, logger="quasardb.writer")
+    logger_name = "quasardb.writer"
+    if qdbpd_write_fn is conftest._write_dataframe_arrow:
+        logger_name = "quasardb.batch_push_arrow"
+
+    caplog.set_level(logging.DEBUG, logger=logger_name)
     qdbpd_write_fn(df, qdbd_connection, table, **kwargs)
 
     assert any(expected in x.message for x in caplog.records)