Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Improve modal dismiss experience #319

@rylek90

Description

@rylek90

I've recently noticed that Modal component's experience might be improved a bit.

Without a closeButton prop modal can be dismissed with an escape button but only if it's pressed within its container. I think it should either: ignore button press at all without closeButton prop or handle it within whole document context. I can push PR with a fix but I need some guidance if it's a reasonable improvement in your opinion 😄

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions