Skip to content

Commit 6a2996c

Browse files
fdmananakdave
authored andcommitted
btrfs: rename rb_root member of extent_map_tree from map to root
Currently we name the rb_root member of struct extent_map_tree as 'map', which is odd and confusing. Since it's a root node, rename it to 'root'. Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 5479739 commit 6a2996c

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

fs/btrfs/extent_map.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void __cold extent_map_exit(void)
3333
*/
3434
void extent_map_tree_init(struct extent_map_tree *tree)
3535
{
36-
tree->map = RB_ROOT_CACHED;
36+
tree->root = RB_ROOT_CACHED;
3737
INIT_LIST_HEAD(&tree->modified_extents);
3838
rwlock_init(&tree->lock);
3939
}
@@ -265,7 +265,7 @@ static void try_merge_map(struct btrfs_inode *inode, struct extent_map *em)
265265
em->generation = max(em->generation, merge->generation);
266266
em->flags |= EXTENT_FLAG_MERGED;
267267

268-
rb_erase_cached(&merge->rb_node, &tree->map);
268+
rb_erase_cached(&merge->rb_node, &tree->root);
269269
RB_CLEAR_NODE(&merge->rb_node);
270270
free_extent_map(merge);
271271
dec_evictable_extent_maps(inode);
@@ -278,7 +278,7 @@ static void try_merge_map(struct btrfs_inode *inode, struct extent_map *em)
278278
if (rb && can_merge_extent_map(merge) && mergeable_maps(em, merge)) {
279279
em->len += merge->len;
280280
em->block_len += merge->block_len;
281-
rb_erase_cached(&merge->rb_node, &tree->map);
281+
rb_erase_cached(&merge->rb_node, &tree->root);
282282
RB_CLEAR_NODE(&merge->rb_node);
283283
em->generation = max(em->generation, merge->generation);
284284
em->flags |= EXTENT_FLAG_MERGED;
@@ -389,7 +389,7 @@ static int add_extent_mapping(struct btrfs_inode *inode,
389389

390390
lockdep_assert_held_write(&tree->lock);
391391

392-
ret = tree_insert(&tree->map, em);
392+
ret = tree_insert(&tree->root, em);
393393
if (ret)
394394
return ret;
395395

@@ -410,7 +410,7 @@ __lookup_extent_mapping(struct extent_map_tree *tree,
410410
struct rb_node *prev_or_next = NULL;
411411
u64 end = range_end(start, len);
412412

413-
rb_node = __tree_search(&tree->map.rb_root, start, &prev_or_next);
413+
rb_node = __tree_search(&tree->root.rb_root, start, &prev_or_next);
414414
if (!rb_node) {
415415
if (prev_or_next)
416416
rb_node = prev_or_next;
@@ -479,7 +479,7 @@ void remove_extent_mapping(struct btrfs_inode *inode, struct extent_map *em)
479479
lockdep_assert_held_write(&tree->lock);
480480

481481
WARN_ON(em->flags & EXTENT_FLAG_PINNED);
482-
rb_erase_cached(&em->rb_node, &tree->map);
482+
rb_erase_cached(&em->rb_node, &tree->root);
483483
if (!(em->flags & EXTENT_FLAG_LOGGING))
484484
list_del_init(&em->list);
485485
RB_CLEAR_NODE(&em->rb_node);
@@ -500,7 +500,7 @@ static void replace_extent_mapping(struct btrfs_inode *inode,
500500
ASSERT(extent_map_in_tree(cur));
501501
if (!(cur->flags & EXTENT_FLAG_LOGGING))
502502
list_del_init(&cur->list);
503-
rb_replace_node_cached(&cur->rb_node, &new->rb_node, &tree->map);
503+
rb_replace_node_cached(&cur->rb_node, &new->rb_node, &tree->root);
504504
RB_CLEAR_NODE(&cur->rb_node);
505505

506506
setup_extent_mapping(inode, new, modified);
@@ -659,11 +659,11 @@ static void drop_all_extent_maps_fast(struct btrfs_inode *inode)
659659
struct extent_map_tree *tree = &inode->extent_tree;
660660

661661
write_lock(&tree->lock);
662-
while (!RB_EMPTY_ROOT(&tree->map.rb_root)) {
662+
while (!RB_EMPTY_ROOT(&tree->root.rb_root)) {
663663
struct extent_map *em;
664664
struct rb_node *node;
665665

666-
node = rb_first_cached(&tree->map);
666+
node = rb_first_cached(&tree->root);
667667
em = rb_entry(node, struct extent_map, rb_node);
668668
em->flags &= ~(EXTENT_FLAG_PINNED | EXTENT_FLAG_LOGGING);
669669
remove_extent_mapping(inode, em);
@@ -1058,7 +1058,7 @@ static long btrfs_scan_inode(struct btrfs_inode *inode, long *scanned, long nr_t
10581058
return 0;
10591059

10601060
write_lock(&tree->lock);
1061-
node = rb_first_cached(&tree->map);
1061+
node = rb_first_cached(&tree->root);
10621062
while (node) {
10631063
struct extent_map *em;
10641064

@@ -1094,7 +1094,7 @@ static long btrfs_scan_inode(struct btrfs_inode *inode, long *scanned, long nr_t
10941094
* lock and took it again.
10951095
*/
10961096
if (cond_resched_rwlock_write(&tree->lock))
1097-
node = rb_first_cached(&tree->map);
1097+
node = rb_first_cached(&tree->root);
10981098
}
10991099
write_unlock(&tree->lock);
11001100
up_read(&inode->i_mmap_lock);

fs/btrfs/extent_map.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ struct extent_map {
115115
};
116116

117117
struct extent_map_tree {
118-
struct rb_root_cached map;
118+
struct rb_root_cached root;
119119
struct list_head modified_extents;
120120
rwlock_t lock;
121121
};

fs/btrfs/tests/extent-map-tests.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ static int free_extent_map_tree(struct btrfs_inode *inode)
1919
int ret = 0;
2020

2121
write_lock(&em_tree->lock);
22-
while (!RB_EMPTY_ROOT(&em_tree->map.rb_root)) {
23-
node = rb_first_cached(&em_tree->map);
22+
while (!RB_EMPTY_ROOT(&em_tree->root.rb_root)) {
23+
node = rb_first_cached(&em_tree->root);
2424
em = rb_entry(node, struct extent_map, rb_node);
2525
remove_extent_mapping(inode, em);
2626

@@ -551,7 +551,7 @@ static int validate_range(struct extent_map_tree *em_tree, int index)
551551
struct rb_node *n;
552552
int i;
553553

554-
for (i = 0, n = rb_first_cached(&em_tree->map);
554+
for (i = 0, n = rb_first_cached(&em_tree->root);
555555
valid_ranges[index][i].len && n;
556556
i++, n = rb_next(n)) {
557557
struct extent_map *entry = rb_entry(n, struct extent_map, rb_node);

0 commit comments

Comments
 (0)