Preparing for the first launch

Author: brickpool

.github/workflows/ci-nightly.yml

@@ -0,0 +1,64 @@
+name: CI Nightly Extended
+
+on:
+  schedule:
+    - cron: "0 3 * * *"   # every night at 03:00 UTC
+  workflow_dispatch:      # manual trigger possible
+
+jobs:
+  extended-windows:
+    name: Extended / Windows ${{ matrix.os }} / Perl ${{ matrix.perl }}
+    runs-on: ${{ matrix.os }}
+    continue-on-error: true
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ windows-2022, windows-latest ]
+        perl: [ "5.10", "5.12", "5.14", "5.16", "5.18", "5.20", "5.32", "5.36", "5.38", "5.40", "latest" ]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: shogo82148/actions-setup-perl@v1
+        with:
+          distribution: strawberry
+          perl-version: ${{ matrix.perl }}
+
+      - shell: pwsh
+        run: perl -V
+
+      - shell: pwsh
+        run: >
+          cpanm --skip-satisfied --quiet --notest
+          autodie::Scope::Guard
+          Carp~1.01
+          Class::Struct
+          Devel::StrictMode~0.003
+          Encode
+          Importer~0.026
+          Import::Into~1.002005
+          List::Util~1.33
+          Module::Loaded
+          Params::Check
+          Scalar::Util~1.36
+          UNIVERSAL::Object~0.17
+          Win32~0.59
+          Win32API::File~0.1101
+          Win32::API~0.84
+          Win32::Console~0.10
+          Win32::Console::PatchForRT33513~0.008
+          Test::Exception~0.43
+          Test::More~0.95
+          Devel::Refcount~0.10
+
+      - shell: pwsh
+        run: |
+          perl Makefile.PL
+          if (Get-Command gmake -ErrorAction SilentlyContinue) {
+            gmake test
+          } elseif (Get-Command dmake -ErrorAction SilentlyContinue) {
+            dmake test
+          } else {
+            make test
+          }

.github/workflows/ci-smoke.yml

@@ -0,0 +1,36 @@
+name: CI Smoke
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+
+jobs:
+  smoke:
+    name: Smoke / Windows / Perl latest
+    runs-on: windows-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: shogo82148/actions-setup-perl@v1
+        with:
+          distribution: strawberry
+          perl-version: latest
+
+      - shell: pwsh
+        run: perl -V
+
+      - shell: pwsh
+        run: >
+          cpanm --skip-satisfied --quiet --notest
+          Devel::StrictMode
+          Importer
+          Import::Into
+          UNIVERSAL::Object
+          Win32::Console::PatchForRT33513
+
+      - shell: pwsh
+        run: |
+          perl Makefile.PL
+          gmake test

Makefile.PL

@@ -1,10 +1,14 @@
-use 5.008;
+use 5.010;
 use strict;
 use warnings;
 
-use ExtUtils::MakeMaker 6.64;
+use ExtUtils::MakeMaker;
 
-WriteMakefile(
+unless ($^O eq "MSWin32" || $^O eq "cygwin") {
+  die "OS unsupported\n";
+}
+
+WriteMakefile1(
   NAME              => 'TUI::Vision',
   AUTHOR            => 'J. Schneider',
   VERSION_FROM      => 'lib/TUI/Vision.pm',
@@ -100,3 +104,37 @@ WriteMakefile(
 
   },
 );
+
+# Taken from eumm-upgrade by Alexandr Ciornii
+sub WriteMakefile1 { # void (%params)
+  my %params = @_;
+  my $eumm_version = $ExtUtils::MakeMaker::VERSION;
+  $eumm_version = eval $eumm_version;
+
+  if ($params{TEST_REQUIRES} and $eumm_version < 6.64) {
+    $params{BUILD_REQUIRES} = {
+      %{$params{BUILD_REQUIRES} || {}},
+      %{$params{TEST_REQUIRES}} 
+    };
+    delete $params{TEST_REQUIRES};
+  }
+  if ($params{BUILD_REQUIRES} and $eumm_version < 6.5503) {
+    #EUMM 6.5502 has problems with BUILD_REQUIRES
+    $params{PREREQ_PM} = {
+      %{$params{PREREQ_PM} || {}},
+      %{$params{BUILD_REQUIRES}} 
+    };
+    delete $params{BUILD_REQUIRES};
+  }
+
+  delete $params{CONFIGURE_REQUIRES} if $eumm_version < 6.52;
+  delete $params{MIN_PERL_VERSION} if $eumm_version < 6.48;
+  delete $params{META_MERGE} if $eumm_version < 6.46;
+  delete $params{META_ADD} if $eumm_version < 6.46;
+  delete $params{LICENSE} if $eumm_version < 6.31;
+  delete $params{AUTHOR} if $] < 5.005;
+  delete $params{ABSTRACT_FROM} if $] < 5.005;
+  delete $params{BINARY_LOCATION} if $] < 5.005;
+
+  WriteMakefile(%params);
+}

lib/TUI/Drivers/HardwareInfo/Win32.pm

@@ -216,21 +216,21 @@ INIT {
   # I<conctl.cpp>
   {
     my $console;
-    my $have_console = 0;
+    my $have_console = false;
 
     $console = Win32::Console->new( STD_INPUT_HANDLE );
     if ( $console && $console->$isValid() ) {
-      $have_console = 1;
+      $have_console = true;
       $consoleHandle[cnInput] = $console;
     }
     $console = Win32::Console->new( STD_OUTPUT_HANDLE );
     if ( $console && $console->$isValid() ) {
-      $have_console = 1;
+      $have_console = true;
       $consoleHandle[cnStartup] = $console;
     }
     $console = Win32::Console->new( STD_ERROR_HANDLE );
     if ( $console && $console->$isValid() ) {
-      $have_console = 1;
+      $have_console = true;
       $consoleHandle[cnStartup] = $console;
     }
 
@@ -244,8 +244,6 @@ INIT {
       # Create a new generic object
       $console = Win32::Console->new();
       if ( $console && $console->$isValid() ) {
-        # If object is a valid console, close the old handle
-        $console->Close();
         # Assign a handle created by CreateFile() to the object
         $console->{handle} = Win32API::File::createFile(
           'CONIN$',
@@ -261,7 +259,6 @@ INIT {
     unless ( $consoleHandle[cnStartup] ) {
       $console = Win32::Console->new();
       if ( $console && $console->$isValid() ) {
-        $console->Close();
         $console->{handle} = Win32API::File::createFile(
           'CONOUT$',
           {
@@ -276,7 +273,8 @@ INIT {
     $console = Win32::Console->new( GENERIC_READ | GENERIC_WRITE, 0 );
     if ( $console && $console->$isValid() ) {
       $consoleHandle[cnOutput] = $console;
-      if ( @sbInfo = $consoleHandle[cnStartup]->Info() ) {
+      if ( ref $consoleHandle[cnStartup] ) {
+        @sbInfo = $consoleHandle[cnStartup]->Info();
         # Force the screen buffer size to match the window size.
         # The Console API guarantees this, but some implementations
         # are not compliant (e.g. Wine).
@@ -298,7 +296,7 @@ INIT {
 
 END {
   $consoleHandle[cnStartup]->Display()
-    if $consoleHandle[cnStartup];
+    if ref $consoleHandle[cnStartup];
   Win32::Console::Free()
     if $ownsConsole;
 }
@@ -321,6 +319,7 @@ sub setCaretSize {    # void ($class, $size)
   my ( $class, $size ) = @_;
   assert ( $class and !ref $class );
   assert ( looks_like_number $size );
+  return unless ref $consoleHandle[cnOutput];
   @crInfo = $consoleHandle[cnOutput]->Cursor();
   if ( $size == 0 ) {
     $crInfo[bVisible] = 0;
@@ -344,6 +343,7 @@ sub setCaretPosition { # void ($class, $x, $y)
   assert ( $class and !ref $class );
   assert ( looks_like_number $x );
   assert ( looks_like_number $y );
+  return unless ref $consoleHandle[cnOutput];
   $consoleHandle[cnOutput]->Cursor($x, $y);
   return;
 }
@@ -382,6 +382,7 @@ sub setScreenMode {    # void ($class, $mode)
   my ( $class, $mode ) = @_;
   assert ( $class and !ref $class );
   assert ( looks_like_number $mode );
+  return unless ref $consoleHandle[cnOutput];
   my %newSize = ( X => 80, Y => 25 );
   my %rect    = ( Left => 0, Top => 0, Right => 79, Bottom => 24 );
 
@@ -416,6 +417,7 @@ sub clearScreen {    # void ($class, $w, $h);
   assert ( $class and !ref $class );
   assert ( looks_like_number $w );
   assert ( looks_like_number $h );
+  return unless ref $consoleHandle[cnOutput];
   $consoleHandle[cnOutput]->FillAttr( 0x07, $w * $h, 0, 0 );
   $consoleHandle[cnOutput]->FillChar( ' ', $w * $h, 0, 0 );
   return;
@@ -428,6 +430,7 @@ sub screenWrite {    # void ($class, $x, $y, $buf, $len)
   assert ( looks_like_number $y );
   assert ( ref $buf );
   assert ( looks_like_number $len );
+  return unless ref $consoleHandle[cnOutput];
   my %to = ( Left => $x, Top => $y, Right => $x + $len - 1, Bottom => $y );
 
   $consoleHandle[cnOutput]->WriteRect( 
@@ -466,6 +469,7 @@ sub getButtonCount {    # $num ($class)
 
 sub cursorOn {    # void ($class)
   assert ( $_[0] and !ref $_[0] );
+  return unless ref $consoleHandle[cnInput];
   # Disable the Quick Edit mode, which inhibits the mouse.
   local $consoleMode = $consoleMode;
   $consoleMode |= ENABLE_EXTENDED_FLAGS;
@@ -476,6 +480,7 @@ sub cursorOn {    # void ($class)
 
 sub cursorOff {    # void ($class)
   assert ( $_[0] and !ref $_[0] );
+  return unless ref $consoleHandle[cnInput];
   $consoleHandle[cnInput]->Mode( $consoleMode & ~ENABLE_MOUSE_INPUT );
   return;
 }
@@ -492,6 +497,7 @@ sub getMouseEvent {    # $bool ($class, $event)
   my ( $class, $event ) = @_;
   assert ( $class and !ref $class );
   assert ( blessed $event );
+  return unless ref $consoleHandle[cnInput];
   if ( !$pendingEvent ) {
     $pendingEvent = $consoleHandle[cnInput]->GetEvents();
     if ( $pendingEvent ) {
@@ -517,6 +523,7 @@ sub getKeyEvent {    # $bool ($class, $event)
   my ( $class, $event ) = @_;
   assert ( $class and !ref $class );
   assert ( blessed $event );
+  return unless ref $consoleHandle[cnInput];
   if ( !$pendingEvent ) {
     $pendingEvent = $consoleHandle[cnInput]->GetEvents();
     if ( $pendingEvent ) {
@@ -588,6 +595,7 @@ sub setCtrlBrkHandler { # $success ($class, $install)
   assert ( @_ == 2 );
   assert ( $class and !ref $class );
   assert ( !defined $install or !ref $install );
+  return unless ref $consoleHandle[cnInput];
   my $consoleMode = $consoleHandle[cnInput]->Mode() || return;
   return $consoleHandle[cnInput]->Mode(
     $install