boutdata/mms.py unused variables and tests?

[mrhardman]

Are the variables below used anywhere?

boutdata/src/boutdata/mms.py

Lines 25 to 27 in f5d308e

	self.x = symbols("x'")
	self.y = symbols("y'")
	self.z = symbols("z'")

I am considering bringing the features from https://github.com/boutproject/hermes-3/blob/nonorthogonal-debug/tests/mms/perpendicular_laplacian.py into boutdata/mms.py. Are there any tests of this module?

[dschwoerer]

I think they may be used by various mms tests, some of which are in BOUT++.

I think the tests are the other way round. If the analytical implementation agrees with the numerical in BOUT++, all is good.

Now that boutdata is not part of BOUT++ anymore, we do not run the tests as part of boutdata any more, so having some kind of smoke test might be nice.

Or we add BOUT++ CI to this as well, to make sure boutdata does not break BOUT++. Unfortunately I have not found a way to do this without lots of pain.