Skip to content

ENH: automatic addition of MS2 property to output of read-ms-experiment#49

Merged
VinzentRisch merged 6 commits intobokulich-lab:mainfrom
VinzentRisch:48_read_ms_experiment_ms2_property
Aug 18, 2025
Merged

ENH: automatic addition of MS2 property to output of read-ms-experiment#49
VinzentRisch merged 6 commits intobokulich-lab:mainfrom
VinzentRisch:48_read_ms_experiment_ms2_property

Conversation

@VinzentRisch
Copy link
Copy Markdown
Member

closes #48

Automatically adds MS2 property to output of read-ms-experiment. By converting the method into a pipeline the type can be specified with a property.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.65%. Comparing base (785917b) to head (726e7a4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           8        8           
  Lines         289      294    +5     
  Branches       38       39    +1     
=======================================
+ Hits          288      293    +5     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VinzentRisch VinzentRisch changed the title ENH: automatic addition of MS2 property to output ENH: automatic addition of MS2 property to output of read-ms-experiment Jul 31, 2025
@VinzentRisch VinzentRisch requested a review from misialq July 31, 2025 11:11
Copy link
Copy Markdown
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥

@VinzentRisch VinzentRisch merged commit 792cbda into bokulich-lab:main Aug 18, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: read-ms-experiment does not automatically assign the property MS2 if MS2-level scans are present

2 participants