fix(api): add safety checks for Odoo supplier sync v2.1.11

Author: eldinmiller

CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to BluePLM will be documented in this file.
 
+## [2.2.0] - UNRELEASED
+
+### Added
+- **Webhooks Integration**: Send HTTP notifications to external services when events occur in BluePLM
+  - Configure webhooks in Settings → Webhooks (admin-only)
+  - 12 event types: file created/updated/deleted, check-in/check-out, state changes, reviews, ECOs
+  - HMAC-SHA256 signature verification for secure payloads
+  - User filtering: trigger webhooks for everyone, specific roles, or specific users
+  - Built-in test button to verify webhook endpoints
+  - Delivery history with status tracking (success, failed, retrying)
+  - Auto-retry failed deliveries with configurable retry count and delay
+  - Enable/disable toggle per webhook
+
+---
+
 ## [2.1.1] - 2025-12-12
 
 ### Fixed

api/server.ts

@@ -610,39 +610,57 @@ async function fetchOdooSuppliers(
 ): Promise<{ success: boolean; suppliers: OdooSupplier[]; error?: string }> {
   const normalizedUrl = normalizeOdooUrl(url)
   try {
+    console.log('[Odoo] Authenticating to:', normalizedUrl)
+    
     // Authenticate first
     const uid = await odooXmlRpc(normalizedUrl, 'common', 'authenticate', [
       database, username, apiKey, {}
     ])
 
+    console.log('[Odoo] Auth result uid:', uid)
+    
     if (!uid || uid === false) {
       return { success: false, suppliers: [], error: 'Authentication failed' }
     }
 
     // Search for suppliers (partners with supplier_rank > 0)
+    console.log('[Odoo] Searching for suppliers...')
     const supplierIds = await odooXmlRpc(normalizedUrl, 'object', 'execute_kw', [
       database, uid, apiKey,
       'res.partner', 'search',
       [[['supplier_rank', '>', 0]]],
       { limit: 5000 }  // Reasonable limit
-    ]) as number[]
+    ])
 
-    if (!supplierIds || supplierIds.length === 0) {
+    console.log('[Odoo] Supplier IDs result:', typeof supplierIds, Array.isArray(supplierIds) ? supplierIds.length : supplierIds)
+    
+    // Ensure supplierIds is an array
+    const ids = Array.isArray(supplierIds) ? supplierIds : []
+    
+    if (ids.length === 0) {
+      console.log('[Odoo] No suppliers found')
       return { success: true, suppliers: [] }
     }
 
     // Read supplier details
-    const suppliers = await odooXmlRpc(normalizedUrl, 'object', 'execute_kw', [
+    console.log('[Odoo] Reading', ids.length, 'supplier details...')
+    const suppliersResult = await odooXmlRpc(normalizedUrl, 'object', 'execute_kw', [
       database, uid, apiKey,
       'res.partner', 'read',
-      [supplierIds, [
+      [ids, [
         'id', 'name', 'ref', 'email', 'phone', 'mobile', 'website',
         'street', 'street2', 'city', 'zip', 'state_id', 'country_id', 'active'
       ]]
-    ]) as OdooSupplier[]
+    ])
+    
+    console.log('[Odoo] Suppliers result type:', typeof suppliersResult, Array.isArray(suppliersResult) ? suppliersResult.length : 'not array')
+    
+    // Ensure result is an array
+    const suppliers = Array.isArray(suppliersResult) ? suppliersResult as OdooSupplier[] : []
 
     return { success: true, suppliers }
   } catch (err) {
+    console.error('[Odoo] Error:', err)
     return { success: false, suppliers: [], error: String(err) }
   }
 }
@@ -3483,10 +3501,25 @@ export async function buildServer(): Promise<FastifyInstance> {
       return reply.code(400).send({ error: 'Sync failed', message: odooSuppliers.error })
     }
 
+    // Safety check - ensure suppliers is an array
+    const suppliers = Array.isArray(odooSuppliers.suppliers) ? odooSuppliers.suppliers : []
+    console.log(`[Odoo Sync] Found ${suppliers.length} suppliers from Odoo`)
+    
+    if (suppliers.length === 0) {
+      return { 
+        success: true, 
+        created: 0, 
+        updated: 0, 
+        skipped: 0, 
+        errors: 0,
+        message: 'No suppliers found in Odoo with supplier_rank > 0' 
+      }
+    }
+    
     // Process suppliers
     let created = 0, updated = 0, skipped = 0, errors = 0
 
-    for (const odooSupplier of odooSuppliers.suppliers) {
+    for (const odooSupplier of suppliers) {
       try {
         // Check if supplier already exists by erp_id
         const { data: existing } = await request.supabase!

package.json

@@ -1,6 +1,6 @@
 {
   "name": "blue-plm",
-  "version": "2.1.10",
+  "version": "2.1.11",
   "description": "Product Lifecycle Management for engineering teams",
   "main": "dist-electron/main.js",
   "scripts": {

src/App.tsx

@@ -2,7 +2,7 @@ import { useEffect, useState, useCallback, useRef } from 'react'
 import { usePDMStore } from './stores/pdmStore'
 import { SettingsContent } from './components/SettingsContent'
 
-type SettingsTab = 'account' | 'vault' | 'organization' | 'branding' | 'metadata-columns' | 'backup' | 'solidworks' | 'google-drive' | 'odoo' | 'slack' | 'webhooks' | 'api' | 'preferences' | 'logs' | 'about'
+type SettingsTab = 'profile' | 'preferences' | 'vault' | 'organization' | 'branding' | 'metadata-columns' | 'backup' | 'solidworks' | 'google-drive' | 'odoo' | 'slack' | 'webhooks' | 'api' | 'logs' | 'about'
 import { supabase, getCurrentSession, isSupabaseConfigured, getFilesLightweight, getCheckedOutUsers, linkUserToOrganization, getUserProfile, setCurrentAccessToken, registerDeviceSession, startSessionHeartbeat, stopSessionHeartbeat } from './lib/supabase'
 import { subscribeToFiles, subscribeToActivity, unsubscribeAll } from './lib/realtime'
 // Backup services removed - now handled directly via restic
@@ -71,16 +71,16 @@ function useTheme() {
     const seasonalTheme = getSeasonalThemeOverride()
 
     // If we're in a seasonal period and user's theme is NOT already the seasonal theme,
-    // auto-switch to the seasonal theme
+    // auto-switch to the seasonal theme (only once per season)
     if (seasonalTheme && theme !== seasonalTheme) {
-      // Check if we've already auto-switched this month (stored in sessionStorage)
+      // Check if we've already auto-switched this season (stored in localStorage to persist across restarts)
       const storageKey = `seasonal-theme-applied-${seasonalTheme}`
-      const alreadyApplied = sessionStorage.getItem(storageKey)
+      const alreadyApplied = localStorage.getItem(storageKey)
 
       if (!alreadyApplied) {
         // Auto-switch to seasonal theme
         setTheme(seasonalTheme)
-        sessionStorage.setItem(storageKey, 'true')
+        localStorage.setItem(storageKey, 'true')
         console.log(`🎃🎄 Auto-applying ${seasonalTheme} theme for the season!`)
       }
     }
@@ -175,7 +175,16 @@ function App() {
   const [isResizingSidebar, setIsResizingSidebar] = useState(false)
   const [isResizingDetails, setIsResizingDetails] = useState(false)
   const [isResizingRightPanel, setIsResizingRightPanel] = useState(false)
-  const [settingsTab, setSettingsTab] = useState<SettingsTab>('account')
+  const [settingsTab, setSettingsTab] = useState<SettingsTab>('profile')
+  
+  // Listen for settings tab navigation from MenuBar buttons
+  useEffect(() => {
+    const handleNavigateSettingsTab = (e: CustomEvent<SettingsTab>) => {
+      setSettingsTab(e.detail)
+    }
+    window.addEventListener('navigate-settings-tab', handleNavigateSettingsTab as EventListener)
+    return () => window.removeEventListener('navigate-settings-tab', handleNavigateSettingsTab as EventListener)
+  }, [])
 
   // Track if Supabase is configured (can change at runtime)
   const [supabaseReady, setSupabaseReady] = useState(() => isSupabaseConfigured())

src/components/MenuBar.tsx

@@ -1,5 +1,5 @@
 import { useState, useEffect, useRef, useCallback } from 'react'
-import { LogOut, ChevronDown, Building2, Search, File, Folder, LayoutGrid, Database, ZoomIn, Minus, Plus, RotateCcw, Monitor, Laptop, Loader2, Settings } from 'lucide-react'
+import { LogOut, ChevronDown, Building2, Search, File, Folder, LayoutGrid, Database, ZoomIn, Minus, Plus, RotateCcw, Monitor, Laptop, Loader2, User, SlidersHorizontal } from 'lucide-react'
 import { usePDMStore } from '../stores/pdmStore'
 import { signInWithGoogle, signOut, isSupabaseConfigured, linkUserToOrganization, getActiveSessions, endRemoteSession, UserSession, supabase } from '../lib/supabase'
 import { getInitials } from '../types/pdm'
@@ -643,17 +643,33 @@ export function MenuBar({ minimal = false }: MenuBarProps) {
                   </div>
                 </div>
 
-                {/* Profile & Settings */}
+                {/* Profile & Preferences */}
                 <div className="py-1 border-b border-plm-border">
                   <button 
                     onClick={() => {
                       setShowUserMenu(false)
                       setActiveView('settings')
+                      setTimeout(() => {
+                        window.dispatchEvent(new CustomEvent('navigate-settings-tab', { detail: 'profile' }))
+                      }, 0)
                     }}
                     className="w-full flex items-center gap-3 px-4 py-2 text-sm text-plm-fg hover:bg-plm-bg-lighter transition-colors"
                   >
-                    <Settings size={14} />
-                    Settings
+                    <User size={14} />
+                    Profile
+                  </button>
+                  <button 
+                    onClick={() => {
+                      setShowUserMenu(false)
+                      setActiveView('settings')
+                      setTimeout(() => {
+                        window.dispatchEvent(new CustomEvent('navigate-settings-tab', { detail: 'preferences' }))
+                      }, 0)
+                    }}
+                    className="w-full flex items-center gap-3 px-4 py-2 text-sm text-plm-fg hover:bg-plm-bg-lighter transition-colors"
+                  >
+                    <SlidersHorizontal size={14} />
+                    Preferences
                   </button>
                 </div>
 

src/components/SettingsContent.tsx

@@ -1,5 +1,6 @@
 import {
-  AccountSettings,
+  ProfileSettings,
+  PreferencesSettings,
   OrganizationSettings,
   CompanyProfileSettings,
   RFQSettings,
@@ -12,10 +13,11 @@ import {
   WebhooksSettings,
   ApiSettings,
   LogsSettings,
-  AboutSettings
+  AboutSettings,
+  SupabaseSettings
 } from './settings'
 
-type SettingsTab = 'account' | 'organization' | 'company-profile' | 'rfq' | 'metadata-columns' | 'backup' | 'solidworks' | 'google-drive' | 'odoo' | 'slack' | 'webhooks' | 'api' | 'logs' | 'about'
+type SettingsTab = 'profile' | 'preferences' | 'organization' | 'company-profile' | 'rfq' | 'metadata-columns' | 'backup' | 'solidworks' | 'google-drive' | 'odoo' | 'slack' | 'webhooks' | 'api' | 'supabase' | 'logs' | 'about'
 
 interface SettingsContentProps {
   activeTab: SettingsTab
@@ -24,8 +26,10 @@ interface SettingsContentProps {
 export function SettingsContent({ activeTab }: SettingsContentProps) {
   const renderContent = () => {
     switch (activeTab) {
-      case 'account':
-        return <AccountSettings />
+      case 'profile':
+        return <ProfileSettings />
+      case 'preferences':
+        return <PreferencesSettings />
       case 'organization':
         return <OrganizationSettings />
       case 'company-profile':
@@ -48,12 +52,14 @@ export function SettingsContent({ activeTab }: SettingsContentProps) {
         return <WebhooksSettings />
       case 'api':
         return <ApiSettings />
+      case 'supabase':
+        return <SupabaseSettings />
       case 'logs':
         return <LogsSettings />
       case 'about':
         return <AboutSettings />
       default:
-        return <AccountSettings />
+        return <ProfileSettings />
     }
   }
 

src/components/Sidebar.tsx

@@ -21,7 +21,7 @@ import { GoogleDriveView } from './sidebar/GoogleDriveView'
 // System Views
 import { SettingsNavigation } from './sidebar/SettingsNavigation'
 
-type SettingsTab = 'account' | 'vault' | 'organization' | 'company-profile' | 'rfq' | 'metadata-columns' | 'backup' | 'solidworks' | 'google-drive' | 'odoo' | 'slack' | 'webhooks' | 'api' | 'preferences' | 'logs' | 'about'
+type SettingsTab = 'profile' | 'preferences' | 'vault' | 'organization' | 'company-profile' | 'rfq' | 'metadata-columns' | 'backup' | 'solidworks' | 'google-drive' | 'odoo' | 'slack' | 'webhooks' | 'api' | 'logs' | 'about'
 
 interface SidebarProps {
   onOpenVault: () => void
@@ -34,7 +34,7 @@ interface SidebarProps {
 // Fixed width for settings view (not resizable)
 const SETTINGS_SIDEBAR_WIDTH = 200
 
-export function Sidebar({ onOpenVault, onOpenRecentVault, onRefresh, settingsTab = 'account', onSettingsTabChange }: SidebarProps) {
+export function Sidebar({ onOpenVault, onOpenRecentVault, onRefresh, settingsTab = 'profile', onSettingsTabChange }: SidebarProps) {
   const { activeView, sidebarWidth, connectedVaults } = usePDMStore()
 
   // Settings view uses fixed width, others use resizable width

src/components/settings/AccountSettings.tsx

@@ -26,6 +26,7 @@ import { signOut, getSupabaseClient, endRemoteSession } from '../../lib/supabase
 import { getInitials } from '../../types/pdm'
 import { getMachineId } from '../../lib/backup'
 import { useTranslation } from '../../lib/i18n'
+import { ContributionHistory } from './ContributionHistory'
 
 interface UserSession {
   id: string
@@ -265,6 +266,9 @@ export function AccountSettings() {
         </div>
       </section>
 
+      {/* Contribution History */}
+      <ContributionHistory />
+
       {/* Sessions */}
       <section>
         <h2 className="text-sm text-plm-fg-muted uppercase tracking-wide font-medium mb-3">