Skip to content

Commit 17d201a

Browse files
committed
Sgn msg from testnet.
1 parent aa52582 commit 17d201a

File tree

4 files changed

+16
-37
lines changed

4 files changed

+16
-37
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "BITBOX",
3-
"version": "0.3.2",
3+
"version": "0.3.3",
44
"description": "A development framework for Bitcoin Cash",
55
"main": "main.js",
66
"productName": "BITBOX",
@@ -30,7 +30,7 @@
3030
"babel-preset-react": "^6.24.1",
3131
"babel-register": "^6.26.0",
3232
"bchaddrjs": "^0.1.4",
33-
"bitbox-cli": "0.3.17",
33+
"bitbox-cli": "0.3.18",
3434
"bitcoinjs-lib": "^3.3.2",
3535
"bitcoinjs-message": "^2.0.0",
3636
"body-parser": "^1.18.2",

src/components/SignAndVerify.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ class SignAndVerify extends Component {
3838
this.props.updateValue('message1Error', privateKeyWIF);
3939
return false;
4040
}
41-
let signature = BitcoinCash.signMessage(this.props.signAndVerify.message1, privateKeyWIF);
42-
this.props.updateValue('signature1', signature.toString('base64'));
41+
42+
let signature = bitbox.BitcoinCash.signMessageWithPrivKey(privateKeyWIF, this.props.signAndVerify.message1);
43+
this.props.updateValue('signature1', signature);
4344
}
4445

4546
verifyMessage() {

src/utilities/BitcoinCash.js

Lines changed: 9 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -3,50 +3,28 @@ import Address from '../models/Address';
33
import Bitcoin from 'bitcoinjs-lib';
44
let BITBOXCli = require('bitbox-cli/lib/bitboxcli').default;
55
let bitbox = new BITBOXCli();
6-
6+
import underscore from 'underscore';
77

88
class BitcoinCash {
9-
static signMessage(message, privateKeyWIF) {
10-
11-
let keyPair;
12-
let errorMsg = '';
13-
try {
14-
keyPair = bitbox.BitcoinCash.fromWIF(privateKeyWIF);
15-
} catch (e) {
16-
errorMsg = e.message;
17-
}
18-
19-
if(errorMsg !== '') {
20-
return errorMsg;
21-
}
22-
23-
let privateKey = keyPair.d.toBuffer(32);
24-
let signature = BitcoinCash.sign(message, privateKeyWIF);
25-
let signature1 = signature.toString('base64')
26-
return signature1;
27-
}
28-
29-
static sign(message, privateKeyWIF) {
30-
return bitbox.BitcoinCash.signMessageWithPrivKey(privateKeyWIF, message);
31-
}
32-
339
static returnPrivateKeyWIF(pubAddress, addresses) {
10+
let encoding;
11+
if(bitbox.BitcoinCash.isCashAddress(pubAddress)) {
12+
encoding = 'cashAddr';
13+
} else {
14+
encoding = 'legacy';
15+
}
3416
let privateKeyWIF;
3517
let errorMsg = '';
3618
try {
37-
addresses.forEach((address, index) => {
38-
if(bitbox.BitcoinCash.toLegacyAddress(pubAddress) === bitbox.BitcoinCash.fromWIF(address.privateKeyWIF).getAddress()) {
39-
privateKeyWIF = address.privateKeyWIF;
40-
}
41-
});
19+
privateKeyWIF = (encoding === 'cashAddr') ? underscore.findWhere(addresses, ({cashAddr: pubAddress})) : underscore.findWhere(addresses, ({legacy: pubAddress}));
4220
} catch (e) {
4321
errorMsg = e.message;
4422
}
4523

4624
if(errorMsg !== '') {
4725
return errorMsg;
4826
} else {
49-
return privateKeyWIF;
27+
return privateKeyWIF.privateKeyWIF;
5028
}
5129
}
5230

src/utilities/Server.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1331,8 +1331,8 @@ class Server {
13311331
}
13321332

13331333
let message = req.body.params[1];
1334-
let signature = BitcoinCash.signMessage(message, privateKeyWIF);
1335-
res.send(signature.toString('base64'));
1334+
let signature = bitbox.BitcoinCash.signMessageWithPrivKey(privateKeyWIF, message);
1335+
res.send(signature);
13361336
});
13371337

13381338
server.post('/signmessagewithprivkey', (req, res) => {

0 commit comments

Comments
 (0)