O(n)

Author: jaskfla

packages/database/src/core/utilities/mergeMultiJoin.js

@@ -1,7 +1,25 @@
-export function mergeMultiJoin(baseMultiJoin, multiJoinToMerge) {
-  if (!multiJoinToMerge) {
-    return baseMultiJoin;
-  }
-  const checkJoinIsUnique = join => !baseMultiJoin.find(j => j.joinWith === join.joinWith);
-  return [...baseMultiJoin].concat(...multiJoinToMerge.filter(checkJoinIsUnique));
+/**
+ * @typedef {import('../BaseDatabase').JoinType} JoinType
+ * @typedef {{
+ *   joinWith: string;
+ *   joinAs?: string;
+ *   joinType?: JoinType;
+ *   joinCondition: [string, string];
+ *   fields?: Record<string, string | undefined>;
+ * }} MultiJoinItem
+ */
+
+/**
+ * @template {readonly MultiJoinItem[]} Base
+ * @param {readonly Base} base
+ * @param {readonly MultiJoinItem[]} source
+ * @returns {[...Base, ...MultiJoinItem[]]}
+ */
+export function mergeMultiJoin(base, source) {
+  if (!source || source.length === 0) return base;
+
+  const existingJoinTables = new Set(base.map(j => j.joinWith));
+  const uniques = source.filter(j => !existingJoinTables.has(j.joinWith));
+
+  return [...base, ...uniques];
 }