Skip to content

Commit f07324f

Browse files
committed
chore: cleanup
1 parent e408d08 commit f07324f

File tree

6 files changed

+7
-22
lines changed

6 files changed

+7
-22
lines changed

.github/workflows/simorgh-e2e-application-nextjs.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ jobs:
2020
CYPRESS_APP_ENV: 'local'
2121

2222
steps:
23-
- name: Show GitHub context
24-
env:
25-
GITHUB_CONTEXT: ${{ toJson(github) }}
26-
run: echo "$GITHUB_CONTEXT"
27-
shell: bash
28-
2923
- name: Checkout
3024
uses: actions/checkout@v4
3125

.github/workflows/simorgh-unit-tests.yml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,13 @@ jobs:
1515
env:
1616
CI: true
1717
LOG_LEVEL: 'error'
18-
WS_UTF_AUTH: ${{ secrets.WS_UTF_AUTH }}
1918

2019
steps:
2120
- uses: actions/checkout@v4
2221
- name: Use Node.js ${{ matrix.node-version }}
2322
uses: actions/setup-node@v4
2423
with:
2524
node-version: ${{ matrix.node-version }}
26-
env:
27-
WS_UTF_TOKEN: ${{ secrets.WS_UTF_AUTH }}
2825

2926
- name: Cache Node Modules
3027
id: cache
@@ -35,20 +32,13 @@ jobs:
3532
ws-nextjs-app/node_modules
3633
key: node-modules-${{ hashFiles('yarn.lock', 'ws-nextjs-app/yarn.lock') }}
3734

38-
# - name: use auth token for yarn
39-
# uses: v-venes/create-npmrc@v1.0.0
40-
# with:
41-
# org_name: bbc
42-
# auth_token: ${{ secrets.WS_UTF_AUTH }}
43-
# always_auth: true
44-
4535
- name: Install Node Modules
46-
# if: steps.cache.outputs.cache-hit != 'true'
36+
if: steps.cache.ohutputs.cache-hit != 'true'
4737
run: |
4838
rm -rf node_modules
4939
git config --global user.email "DESimorghMaintainers@bbc.co.uk"
5040
git config --global user.name "ws-simorgh-unified-framework"
51-
git config --global url.https://${{ secrets.WS_UTsF_AUTH }}@github.com/.insteadOf https://github.com/
41+
git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
5242
./scripts/installNodeModules.sh
5343
5444
- name: Build Simorgh - Express App

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"test:puppeteer": "jest --ci --colors --verbose ./puppeteer",
6464
"test:puppeteer:local": "PUPPETEER_APP_ENV=local yarn test:puppeteer",
6565
"test:unit": "test -z $CI && yarn test:unit:local || yarn test:unit:ci",
66-
"test:unit:local": "NODE_OPTIONS=--experimental-vm-modules jest --colors --shard=1/1 --testPathIgnorePatterns=\"src/integration/pages\" \"scripts/bundleSize\" \"puppeteer\" \"ws-nextjs-app\"",
66+
"test:unit:local": "NODE_OPTIONS=--experimental-vm-modules jest --colors --shard=1/1 --testPathIgnorePatterns=\"src/integration/pages\" \"scripts/bundleSize\" \"puppeteer\" \"ws-nextjs-app\" \"playwright\"",
6767
"test:unit:ci": "yarn test:unit:local --ci",
6868
"test:unit:scripts": "jest --colors --testPathPatterns=\"scripts/bundleSize/\"",
6969
"test:unit:onetest": "test -z && NODE_OPTIONS=--experimental-vm-modules jest --colors --testPathPatterns=\"src/server/\" || NODE_OPTIONS=--experimental-vm-modules jest --ci --runInBand --colors --testPathPatterns=\"src/server/\"",

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,5 @@
4343
}
4444
},
4545
"include": ["src/**/*", "src/app/legacy/**/*.ts*"],
46-
"exclude": ["node_modules", "build"]
46+
"exclude": ["node_modules", "build", "ws-nextjs-app/playwright/**/*.ts"]
4747
}

ws-nextjs-app/playwright/support/runtTestForPage.playwright.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { test as base, expect } from '@playwright/test';
1+
import { test as base } from '@playwright/test';
22

33
type TestType = (props: any, page: any) => void;
44

ws-nextjs-app/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"build",
2828
"src/app/legacy/**/*",
2929
"cypress",
30-
"cypress.config.ts"
30+
"cypress.config.ts",
31+
"playwright/**/*.ts"
3132
]
3233
}

0 commit comments

Comments
 (0)