Editor link autocomplete doesn't work with keyboard

[olafgrabienski]

Description of the bug

Choosing an internal page in the link dialog with CKEditor or TinyMCE works only if you select a page from the suggestions with the mouse. If you select the page with the keyboard, the path won't be completed.

Steps To Reproduce

To reproduce the behavior:

1. Create a page, and add some text.
2. Select a passage of the text, and open the link dialog.
3. Start to type the title of an existing page, e.g. of the About page.
4. Use the arrow down key of your keyboard to highlight the page from the list of suggestions, and hit Enter.

Actual behavior

The link dialog gets closed, and the link is created, but the path isn't complete.
Result: <a href="/abo">About</a>

Expected behavior

The path gets completed without closing the dialog, as if you select a page using the mouse, and you have to save the dialog explicitely.
Result: <a href="/about">About</a>

Additional information

Add any other information that could help, such as:

• Backdrop CMS version: 1.33.0, but experienced it also in older versions
• Operating System: Mac OS
• Browser(s): current Firefox and Chrome

[olafgrabienski]

In addition, I observed two interesting things:

1. After selecting a page with the keyboard and hitting Enter, just before the dialog gets closed, it looks as if the path gets completed. However, after this, when you switch the editor to source mode, you can see it's not complete.
2. The autocomplete of a link field doesn't have the keyboard issue, maybe because there isn't a modal dialog.

[argiepiano]

Confirmed. This works if, instead of Enter you hit tab.

My guess is that the Enter key is somehow triggering the Link form submission before the link field is populated. Hitting Tab selects the choice and gives it time to populate.

Added info: as pointed out above, link fields in nodes don't act this way. Pressing enter on top of a choice provided by the path-autocomplete will not submit the edit form.

[olafgrabienski]

Thanks for confirming the issue!

Presumably, no one would normally think to use the tab key, but it's an interesting workaround for the time being.

I hope we find a fix. I know some editors of 'my' sites ran into the issue, leading to incomplete links without noticing it directly.

Note: I've updated the "Expected behavior" in the issue description to make clear that the link path should get completed without closing the dialog.