!!![TASK] drop TYPO3 < 13 Support

Author: achimfritz

.github/workflows/ci.yml

@@ -8,7 +8,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        TYPO3: [ '12', '13', '14' ]
+        TYPO3: [ '13', '14' ]
+        php: [ '8.2', '8.5']
 
     steps:
       - name: Checkout
@@ -17,7 +18,7 @@ jobs:
       - name: Set up PHP Version
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: ${{ matrix.php }}
           tools: composer:v2
 
       - name: Start MySQL
@@ -40,19 +41,12 @@ jobs:
         if: matrix.TYPO3 == '13'
         run: |
           composer require typo3/cms-core:^13.4 --no-progress --no-interaction --dev -W
-      - name: Install composer dependencies TYPO3 12
-        if: matrix.TYPO3 == '12'
-        run: |
-          composer require typo3/cms-core:^12.4 --no-progress --no-interaction --dev -W
       - name: Phpstan 13
         if: matrix.TYPO3 == '13'
         run: .Build/bin/phpstan analyze -c Build/phpstan13.neon
       - name: Phpstan 14
         if: matrix.TYPO3 == '14'
         run: .Build/bin/phpstan analyze -c Build/phpstan.neon
-      - name: Phpstan 12
-        if: matrix.TYPO3 == '12'
-        run: .Build/bin/phpstan analyze -c Build/phpstan12.neon
       - name: Phpcsfix
         run: .Build/bin/php-cs-fixer fix --config=Build/php-cs-fixer.php --dry-run --stop-on-violation --using-cache=no
       - name: Functional Tests

Build/phpstan-baseline.neon

@@ -1,8 +1,6 @@
-includes:
-  - phpstan-baseline.neon
 parameters:
   level: 5
   paths:
     - %currentWorkingDirectory%/Classes
   excludePaths:
-    - %currentWorkingDirectory%/Classes/Hooks/DrawItem.php
+    - %currentWorkingDirectory%/Classes/Listener/PageContentPreviewRendering.php

Build/phpstan.neon

@@ -1,6 +1,4 @@
 parameters:
   level: 5
   paths:
-    - %currentWorkingDirectory%/Classes
-  excludePaths:
-    - %currentWorkingDirectory%/Classes/Hooks/DrawItem.php
+    - %currentWorkingDirectory%/Classes

Build/phpstan11.neon

@@ -13,20 +13,17 @@
  */
 
 use B13\Listelements\Service\ListService;
+use Symfony\Component\DependencyInjection\Attribute\Autoconfigure;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Frontend\ContentObject\ContentDataProcessor;
 use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 use TYPO3\CMS\Frontend\ContentObject\DataProcessorInterface;
 
+#[Autoconfigure(public: true)]
 class ListItemsDataProcessor implements DataProcessorInterface
 {
-    protected ListService $listService;
-    protected ContentDataProcessor $contentDataProcessor;
-
-    public function __construct(ListService $listService, ContentDataProcessor $contentDataProcessor)
+    public function __construct(protected ListService $listService, protected ContentDataProcessor $contentDataProcessor)
     {
-        $this->listService = $listService;
-        $this->contentDataProcessor = $contentDataProcessor;
     }
 
     public function process(

Build/phpstan12.neon

@@ -14,15 +14,14 @@
 
 use B13\Listelements\Service\ListService;
 use TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent;
+use TYPO3\CMS\Core\Attribute\AsEventListener;
 use TYPO3\CMS\Core\Information\Typo3Version;
 
+#[AsEventListener(identifier: 'b13-listelements-page-content-preview-rendering')]
 class PageContentPreviewRendering
 {
-    protected ListService $listService;
-
-    public function __construct(ListService $listService)
+    public function __construct(protected ListService $listService)
     {
-        $this->listService = $listService;
     }
 
     public function __invoke(PageContentPreviewRenderingEvent $event): void

Build/phpstan13.neon

@@ -17,13 +17,11 @@
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Database\RelationHandler;
 use TYPO3\CMS\Core\Domain\Repository\PageRepository;
-use TYPO3\CMS\Core\Information\Typo3Version;
 use TYPO3\CMS\Core\Resource\FileRepository;
-use TYPO3\CMS\Core\SingletonInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Versioning\VersionState;
 
-class ListService implements SingletonInterface
+class ListService
 {
     private const TABLE = 'tx_listelements_item';
 
@@ -79,9 +77,6 @@ public function resolveListitems(array $row, string $field = 'tx_listelements_li
 
     protected function isDeletePlaceHolder(array $item): bool
     {
-        if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 13) {
-            return VersionState::cast($item['t3ver_state'] ?? 0)->equals(VersionState::DELETE_PLACEHOLDER);
-        }
         return VersionState::tryFrom($item['t3ver_state'] ?? 0) === VersionState::DELETE_PLACEHOLDER;
     }
 
@@ -91,18 +86,14 @@ public function resolveItemsForFrontend(int $uid, string $table = 'tt_content',
         $pageRepository = GeneralUtility::makeInstance(PageRepository::class);
         $relationHandler = GeneralUtility::makeInstance(RelationHandler::class);
         $relationHandler->setWorkspaceId($workspaceId);
-        if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 13) {
-            $additionalWhere = $pageRepository->enableFields(self::TABLE);
+        $constraints = $pageRepository->getDefaultConstraints(self::TABLE);
+        if ($constraints === []) {
+            $additionalWhere = '';
         } else {
-            $constraints = $pageRepository->getDefaultConstraints(self::TABLE);
-            if ($constraints === []) {
-                $additionalWhere = '';
-            } else {
-                $expressionBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
-                    ->getQueryBuilderForTable($table)
-                    ->expr();
-                $additionalWhere = ' AND ' . $expressionBuilder->and(...$constraints);
-            }
+            $expressionBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
+                ->getQueryBuilderForTable($table)
+                ->expr();
+            $additionalWhere = ' AND ' . $expressionBuilder->and(...$constraints);
         }
         $relationHandler->additionalWhere[self::TABLE] = $additionalWhere;
         $relationHandler->start(