[TASK] prepare v2

Author: achimfritz

Classes/DataProcessing/ListItemsDataProcessor.php

@@ -13,20 +13,17 @@
  */
 
 use B13\Listelements\Service\ListService;
+use Symfony\Component\DependencyInjection\Attribute\Autoconfigure;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Frontend\ContentObject\ContentDataProcessor;
 use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 use TYPO3\CMS\Frontend\ContentObject\DataProcessorInterface;
 
+#[Autoconfigure(public: true)]
 class ListItemsDataProcessor implements DataProcessorInterface
 {
-    protected ListService $listService;
-    protected ContentDataProcessor $contentDataProcessor;
-
-    public function __construct(ListService $listService, ContentDataProcessor $contentDataProcessor)
+    public function __construct(protected ListService $listService, protected ContentDataProcessor $contentDataProcessor)
     {
-        $this->listService = $listService;
-        $this->contentDataProcessor = $contentDataProcessor;
     }
 
     public function process(

Classes/Listener/PageContentPreviewRendering.php

@@ -14,15 +14,14 @@
 
 use B13\Listelements\Service\ListService;
 use TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent;
+use TYPO3\CMS\Core\Attribute\AsEventListener;
 use TYPO3\CMS\Core\Information\Typo3Version;
 
+#[AsEventListener(identifier: 'b13-listelements-page-content-preview-rendering')]
 class PageContentPreviewRendering
 {
-    protected ListService $listService;
-
-    public function __construct(ListService $listService)
+    public function __construct(protected ListService $listService)
     {
-        $this->listService = $listService;
     }
 
     public function __invoke(PageContentPreviewRenderingEvent $event): void

Classes/Service/ListService.php

@@ -19,11 +19,10 @@
 use TYPO3\CMS\Core\Domain\Repository\PageRepository;
 use TYPO3\CMS\Core\Information\Typo3Version;
 use TYPO3\CMS\Core\Resource\FileRepository;
-use TYPO3\CMS\Core\SingletonInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Versioning\VersionState;
 
-class ListService implements SingletonInterface
+class ListService
 {
     private const TABLE = 'tx_listelements_item';
 
@@ -79,9 +78,6 @@ public function resolveListitems(array $row, string $field = 'tx_listelements_li
 
     protected function isDeletePlaceHolder(array $item): bool
     {
-        if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 13) {
-            return VersionState::cast($item['t3ver_state'] ?? 0)->equals(VersionState::DELETE_PLACEHOLDER);
-        }
         return VersionState::tryFrom($item['t3ver_state'] ?? 0) === VersionState::DELETE_PLACEHOLDER;
     }
 

Configuration/Services.yaml

@@ -6,13 +6,3 @@ services:
 
   B13\Listelements\:
     resource: '../Classes/*'
-
-  B13\Listelements\Hooks\DrawItem:
-    public: true
-  B13\Listelements\DataProcessing\ListItemsDataProcessor:
-    public: true
-  B13\Listelements\Listener\PageContentPreviewRendering:
-    tags:
-      - name: event.listener
-        event: TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent
-        identifier: 'b13-listelements-page-content-preview-rendering'

Configuration/Sets/listelements/setup.typoscript

@@ -22,3 +22,5 @@ lib.contentElement {
 		}
 	}
 }
+
+# not required if you use record-transformation dataProcessing, s. README.md

README.md

@@ -22,6 +22,33 @@ content element's Fluid template, like this:
 </f:for>
 ```
 
+### alternative: record-transformation dataProcessing
+
+if you use record-transformation dataProcessing for your content-elements the EXT:listelements Site-Set (the TypoScript) is not required
+you can do
+
+    tt_content.<my-ce>.dataProcessing.10 = record-transformation
+
+then you have adapt your templates, e.g.
+
+```
+<f:for each="{record.tx_listelements_list}" as="item">
+    ...    
+</f:for>
+```
+
+and also the items self, e.g.
+
+    {item.header}
+    {item.images}
+
+instead of
+
+    {item.data.header}
+    {item.listimages}
+
+s. https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/DataProcessing/RecordTransformationProcessor.html
+
 ## Backend PageLayoutView preview
 
 This extension adds a PageContentPreviewRendering Listener to resolve ListItems (and if needed further Relations to asses/images) to allow customized display using Fluid templates for the backend Page

Tests/Functional/Fixture/Extensions/listelements-example/Configuration/TCA/Overrides/pages.php

@@ -16,7 +16,6 @@
                 'showSynchronizationLink' => false,
                 'showAllLocalizationLink' => true,
                 'showPossibleLocalizationRecords' => true,
-                'showRemovedLocalizationRecords' => true,
                 'expandSingle' => true,
                 'newRecordLinkAddTitle' => false,
                 'newRecordLinkTitle' => 'LLL:EXT:listelements/Resources/Private/Language/locallang_db.xlf:tt_content.list.newRecordLinkAddTitle',

Tests/Functional/Fixture/Extensions/listelements-example/Configuration/TypoScript/setup.typoscript

@@ -1,6 +1,6 @@
 
 @import 'EXT:fluid_styled_content/Configuration/TypoScript/setup.typoscript'
-@import 'EXT:listelements/Configuration/TypoScript/setup.typoscript'
+@import 'EXT:listelements/Configuration/Sets/listelements/setup.typoscript'
 
 tt_content.header {
   templateName = Header

Tests/Functional/Frontend/FrontendTest.php

@@ -12,6 +12,7 @@
  * of the License, or any later version.
  */
 
+use PHPUnit\Framework\Attributes\Test;
 use TYPO3\TestingFramework\Core\Functional\Framework\Frontend\InternalRequest;
 use TYPO3\TestingFramework\Core\Functional\Framework\Frontend\InternalRequestContext;
 use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
@@ -38,9 +39,7 @@ class FrontendTest extends FunctionalTestCase
         'listelements_example',
     ];
 
-    /**
-     * @test
-     */
+    #[Test]
     public function itemIsRendered(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/single_element.csv');
@@ -57,9 +56,7 @@ public function itemIsRendered(): void
         self::assertStringContainsString('listitem-header', $body);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function workspaceItemIsRenderedInWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -81,9 +78,7 @@ public function workspaceItemIsRenderedInWorkspace(): void
         self::assertStringNotContainsString('listitem-header', $body);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function worspaceItemIsNotRenderedInNonWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -104,9 +99,7 @@ public function worspaceItemIsNotRenderedInNonWorkspace(): void
         self::assertStringContainsString('listitem-header', $body);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function workspaceItemsIsRenderedInCorrectOrderInWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -127,9 +120,7 @@ public function workspaceItemsIsRenderedInCorrectOrderInWorkspace(): void
         self::assertStringContainsString('first item header-listelement-ws', $body);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function deletedworkspaceItemIsNotRenderedInWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -150,9 +141,7 @@ public function deletedworkspaceItemIsNotRenderedInWorkspace(): void
         self::assertStringNotContainsString('listitem-header', $body);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function pageItemIsRendered(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/page.csv');

Tests/Functional/Service/ListServiceTest.php

@@ -13,6 +13,7 @@
  */
 
 use B13\Listelements\Service\ListService;
+use PHPUnit\Framework\Attributes\Test;
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
 use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Context\WorkspaceAspect;
@@ -37,9 +38,7 @@ class ListServiceTest extends FunctionalTestCase
         'listelements',
     ];
 
-    /**
-     * @test
-     */
+    #[Test]
     public function itemIsFound(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/single_element.csv');
@@ -51,9 +50,7 @@ public function itemIsFound(): void
         self::assertSame('listitem-header', $row['listitems'][0]['header']);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function workspaceItemIsFoundInWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -67,9 +64,7 @@ public function workspaceItemIsFoundInWorkspace(): void
         self::assertSame('header-listelement-ws', $row['listitems'][0]['header']);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function liveItemIsFoundInNonWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -82,9 +77,7 @@ public function liveItemIsFoundInNonWorkspace(): void
         self::assertSame('listitem-header', $row['listitems'][0]['header']);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function deletedWorkspaceItemsAreNotListedInWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');
@@ -96,9 +89,7 @@ public function deletedWorkspaceItemsAreNotListedInWorkspace(): void
         self::assertSame(0, count($row['listitems']));
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function workspaceItemsHasCorrectOrderInWorkspace(): void
     {
         $this->importCSVDataSet(__DIR__ . '/../Fixture/workspace.csv');