[Core] - Death Knight's "Path of Frost" interacts with campfire when it shouldn't

[TheSCREWEDSoftware]

Triage

Issue linked from CC: chromiecraft/chromiecraft#9262

Triage Notes:

• Make a DK
• .cast 3714
• .cast 818
• See that spell keeps procing on the fireplace (i tried onfeasts and itd didn't on them), in mop does does no affect the fireplace.

According to combat log is hitting a invisible trigger

Which is most likely related / similiar to this origin of the issue to a point: chromiecraft/chromiecraft#9135

Original Post Below:

---

Current Behaviour

The DK Path of Frost spell gives you and your party members, pets, etc water walking. This makes a 'fwhoosh' sound effect when it procs.

Currently this also procs on the cooking skill basic campfire placeable (and perhaps other misc things, haven't tested it deeply) which will repeatedly proc causing a very annoying FWHOOSH. FWHOOSH. FWHOOSH. This is likely because campfires aren't targetable and can't have buffs.

campfire.mp4

Expected Behaviour

Campfires should not be affected by Path of Frost. Both because it's kinda silly but also because of QoL

Source

I don't have a video on-hand for such a weird misc. interaction but the wowhead classic wotlk screenshot showcases the campfire not being affected.
https://wow.zamimg.com/uploads/screenshots/normal/130981-path-of-frost.jpg

Steps to reproduce the problem

1. Cast Path of Frost (spell 3714) on yourself
2. Cast Basic Campfire (spell 818)
3. Stand next to the campfire

Extra Notes

No response

Customizations

I don't have any client patches aside from the chromiecraft challenge mode patch and some basic UI addons (which should not cause problems)

AC rev. hash/commit

chromiecraft@00b3b48

Operating system

Ubuntu 22.04

Modules

• mod-1v1-arena
• mod-ah-bot
• mod-anticheat
• mod-arena-3v3-solo-queue
• mod-arena-replay
• mod-bg-item-reward
• mod-breaking-news-override
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-chromiecraft-smartstone
• mod-costumes
• mod-cta-switch
• mod-desertion-warnings
• mod-dmf-switch
• mod-duel-reset
• mod-eluna
• mod-evade-logging
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-npc-spectator
• mod-progression-system
• mod-pvp-quests
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-resurrection-scroll
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-CarbonCopy
• lua-eventScripts
• lua-ExchangeNpc
• lua-LevelUpReward
• lua-RecruitAFriend
• lua-SendAndBind
• lua-TempAnnouncements
• lua-Zonecheck

Server

ChromieCraft

[heyitsbench]

This would be resolved with proper gameobject casting, as there'd be no need to be spawning the trigger.

[Nyeriah]

Soon (tm)

If it isn’t game breaking we can wait definitely

[TheSCREWEDSoftware]

For Path of Frost is just a audiable annoyance. I've the eruption one to check, that one might be an issue