Rename the attribute

Author: hehe7318

cookbooks/aws-parallelcluster-platform/attributes/platform.rb

@@ -30,7 +30,7 @@
 default['cluster']['nvidia']['nvlsm']['enabled'] = true
 
 # DCV
-default['cluster']['dcv']['skip_install'] = false
+default['cluster']['dcv']['install_enabled'] = true
 default['cluster']['dcv']['authenticator']['user'] = "dcvextauth"
 default['cluster']['dcv']['authenticator']['user_id'] = node['cluster']['reserved_base_uid'] + 3
 default['cluster']['dcv']['authenticator']['group'] = node['cluster']['dcv']['authenticator']['user']

cookbooks/aws-parallelcluster-platform/resources/dcv/partial/_dcv_common.rb

@@ -100,8 +100,8 @@ def optionally_disable_rnd
 end
 
 action :setup do
-  if node['cluster']['dcv']['skip_install']
-    Chef::Log.warn("Skipping DCV installation because node['cluster']['dcv']['skip_install'] is set to true")
+  unless node['cluster']['dcv']['install_enabled']
+    Chef::Log.warn("Skipping DCV installation because node['cluster']['dcv']['install_enabled'] is set to false")
     return
   end
   return if dcv_installed?

cookbooks/aws-parallelcluster-platform/spec/unit/resources/dcv_spec.rb

@@ -657,11 +657,11 @@ def self.nothing(chef_run)
         end
       end
 
-      context "when skip_install is true" do
+      context "when install_enabled is false" do
         cached(:chef_run) do
           runner = runner(platform: platform, version: version, step_into: ['dcv']) do |node|
             node_setup.call(node)
-            node.override['cluster']['dcv']['skip_install'] = true
+            node.override['cluster']['dcv']['install_enabled'] = false
           end
           stubs_for_resource('dcv') do |res|
             allow(res).to receive(:dcv_sha256sum).and_return(checksum)
@@ -682,7 +682,7 @@ def self.nothing(chef_run)
           ConvergeDcv.setup(runner)
         end
 
-        it 'skips dcv installation' do
+        it 'does not install dcv when install_enabled is false' do
           is_expected.not_to create_if_missing_cookbook_file("#{scripts_dir}/pcluster_dcv_connect.sh")
           is_expected.not_to create_group(authenticator_group)
           is_expected.not_to create_user(authenticator_user)