Open
Conversation
Introduces footprint_halo(comp, outer_delta, inner_delta) which computes halos from a component's footprint geometry rather than per-element offsets. Significantly faster for components with simple bounding shapes. - New footprint_halo function in components.jl with layer replication - footprint(::Ellipse) identity method in polygons.jl - ExampleStarIsland migrated to use footprint_halo (10 lines -> 2 lines) - Tests for multi-layer, only_layers, inner_delta, and memoization - Updated autofill.md documentation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components can implement their own
halofunction to customize or simply to speed up exclusion area calculation. A common pattern is to specializefootprint, which should return a singleGeometryEntitycovering the entire component, and then delegatehalotoSchematicDrivenLayout.footprint_halo:footprint_halooffsets the footprint once and replicates it across all matching layers in the component, handling memoization and layer filtering automatically. This avoids the per-element, per-layer Clipper calls of the defaulthalo.Previously this required a lot of boilerplate.