backend/gds: Normalize angles upon export#203
Merged
gpeairs merged 1 commit intoaws-cqc:mainfrom Apr 16, 2026
Merged
Conversation
gjnorris-cqc
force-pushed
the
gjnorris/add-gds-rotation-normalization
branch
from
3016b9c to
47dc7fb
Compare
Member
|
I think it’s fine to normalize unconditionally and silently, it costs almost nothing and I can’t think of a reason the user would want to track the difference between 180 and 540. So I suggest
|
gjnorris-cqc
force-pushed
the
gjnorris/add-gds-rotation-normalization
branch
from
47dc7fb to
f2f343b
Compare
gjnorris-cqc
changed the title
Contributor
Author
|
Thanks for the feedback. I have implemented your suggested changes in the latest version. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During routing, angles can accumulate, resulting in values which are outside the GDS spec of [-360, 360]. This results in warnings from tools like Klayout.
This PR adds an option to warn about invalid angles during export (on by default) and to normalize the angles (off by default).