Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
We need a solution that works for rendering styled ClippedPolygons, but I don't want to start pulling apart the to_polygons -> render! separation. Maybe it's enough to self-union any big polygon so it takes the ClippedPolygon guillotine path anyway? |
|
Looks like the guillotine cut interaction was a red herring -- |
laylagi
left a comment
There was a problem hiding this comment.
LGTM, it fixes the issue in my example. Thank you!
Fixes #175.
Right now
_normalize_clip_argturns ClippedPolygons into polygons viainteriorcuts, but we can just extract the oriented contours directly. This then lets us do the guillotine cut for ClippedPolygons with more points thanGDS_POLYGON_MAXwithout an intermediateinteriorcuts, which fixes the mentioned issue. [Edit: it doesn't, see comments further down on how we actually fix the issue.]In a follow-up, we can probably do the same for offsets of ClippedPolygons, which should address the issue where shrinking a polygon with an interior cut pulls it open. [This is still probably a good idea.]