Use tolerance-based discretization for CurvilinearPolygon curves#195
Merged
Use tolerance-based discretization for CurvilinearPolygon curves#195
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gpeairs
reviewed
Apr 1, 2026
Member
gpeairs
left a comment
gpeairs
left a comment
There was a problem hiding this comment.
Looks good, thanks! Confirmed that this reduces point counts in practical cases with only slivers of difference.
In another PR we have an is_sliver test utility to check whether differences are within tolerance or not (heuristic 2*area/perimeter < atol). The tests here are fine as they are, but that will be available in the future.
gpeairs
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentioned in #47. Replaces hardcoded 181-point uniform sampling with discretize_curve/discretization_grid, which adapts point density to curvature and the atol parameter.