Skip to content

Commit be8c692

Browse files
committed
fixup: Respond to review feedback.
Change-Id: I1a3b71bfbd768c84bdfd6911acbcd129d839d3bb
1 parent 133e479 commit be8c692

2 files changed

Lines changed: 13 additions & 11 deletions

File tree

.github/actions/setup-bazel/configure-bazelrc.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ BAZEL_REMOTE_CACHE_ENABLED="${BAZEL_REMOTE_CACHE_ENABLED:-true}"
1313
BAZEL_REMOTE_CACHE_URL="${BAZEL_REMOTE_CACHE_URL:-}"
1414
BAZEL_REMOTE_CACHE_AUTH_HEADER="${BAZEL_REMOTE_CACHE_AUTH_HEADER:-}"
1515

16+
if [[ "$BAZEL_REMOTE_CACHE_ENABLED" == "true" && -z "$BAZEL_REMOTE_CACHE_AUTH_HEADER" ]]; then
17+
echo "::warning::Bazel remote cache is enabled but BAZEL_REMOTE_CACHE_AUTH_HEADER is empty; continuing without the remote cache."
18+
fi
19+
1620
if [[ "$BAZEL_REMOTE_CACHE_ENABLED" == "true" && -n "$BAZEL_REMOTE_CACHE_URL" && -n "$BAZEL_REMOTE_CACHE_AUTH_HEADER" ]]; then
1721
case "$BAZEL_REMOTE_CACHE_URL" in
1822
grpcs://*) ;;

docs/bazel.md

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -705,16 +705,13 @@ This value is an estimate, not a wall-clock limit for the Bazel command. A
705705
command can make multiple RPCs. Retry delays and other build work also add time.
706706
Use command and job timeouts to set a limit for the complete CI operation.
707707

708-
Pre-merge jobs use these job-level limits:
709-
710-
- setup: 10 minutes
711-
- unit tests: 30 minutes
712-
- E2E tests: 30 minutes
713-
- aggregate required job: 5 minutes
714-
715-
Scheduled jobs use twice these limits. They run broader tests without the remote
716-
cache. Bazel's test timeouts still limit each test process. The job-level limits
717-
also cover loading, analysis, builds, downloads, retries, and test setup.
708+
CI job timeouts bound the complete operation. The timeout values are configured
709+
in `.github/workflows/bazel-ci.yml` and
710+
`.github/workflows/bazel-ci-smoke.yml`. Scheduled jobs configure their longer
711+
limits in `.github/workflows/bazel-ci-scheduled.yml`. They run broader tests
712+
without the remote cache. Bazel's test timeouts still limit each test process.
713+
The job-level limits also cover loading, analysis, builds, downloads, retries,
714+
and test setup.
718715

719716
Tests with Bazel 8.8.0 confirmed the expected behavior. An HTTP cache download
720717
continued beyond 120 seconds when a proxy limited traffic to 1 KiB/s. The test
@@ -852,7 +849,8 @@ preserve these invariants:
852849
by the Bazel CI reusable workflows
853850
- cache-prefetch behavior stays focused on external repositories and does not
854851
start depending on developer-specific workspace state
855-
- remote caching requires the cache URL and the authorization header
852+
- when enabled, remote caching requires a `grpcs://` cache URL and the
853+
authorization header
856854
- the daily scheduled workflow disables remote caching
857855
- setup does not print the remote-cache authorization header
858856

0 commit comments

Comments
 (0)