Allow disabling NotificationIssue behavior that communicates with github and is.gd

[Goodwine]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

NotificationIssue seems to report stacktraces and send requests to Github and is.gd. I understand how important this is and I agree that it's useful, so I think it's OK to have this turned on by default.

However IMO we should be able to disable this behavior as I may not want to communicate with those services. Could an option be added for this?

A workaround is to disable this package entirely, but then I have no notifications 😢

Notably, this also happens when no consent for metrics or error reporting is given because apparently the notification checks for existing issues immediately without any active user involvement at that point.

This is not expected behavior, because the initial metrics consent screen also covers exception reporting if I recall correctly. Therefore, NotificationIssue shouldn't automatically contact GitHub in any way if the initial metrics consent wasn't given. With buttons to report or look up existing issues is a different story, but right now this seems to be done immediately without any clicks or anything by the user as soon as an exception happened.

[sneak]

This is a major issue - the software is leaking user usage data even after they have explicitly opted out.

[UziTech]

I have added a PR (UziTech#9) to notifications-plus to check telemetry setting before using github api.

A workaround is to disable this package entirely, but then I have no notifications 😢

notifications-plus is a fork of the notifications package with a few additions:

• updated dependencies
• a status bar element showing number of notifications
• setting to disable certain notifications
• a few extra buttons on error notifications
• a few fixes

[rubencaro]

Is anything being done with this? It doesn't look as a huge change (maybe just to check for atom.config.get("core.telemetryConsent") before doing anything).

As @sneak said, this is a major issue - the software is leaking user usage data even after they have explicitly opted out. I as a user do not expect requests being made to GitHub (or anyone) after opting out to that.

And as @Goodwine mentioned, this is requesting to add the option, not to change default behavior.