[Bug]: ESLint Aspect - missing env variables

[TroyKomodo]

What happened?

Running the eslint_asepct via lint_test causes the binary to have no env variables.

Version

Development (host) and target OS/architectures: Linux 6.12.35 #1-NixOS SMP PREEMPT_DYNAMIC Fri Jun 27 10:11:46 UTC 2025 x86_64 unknown

Output of bazel --version: bazel 8.3.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

bazel_dep(name = "rules_shell", version = "0.5.0")
bazel_dep(name = "aspect_rules_js", version = "2.5.0")
bazel_dep(name = "rules_nodejs", version = "6.5.0")
bazel_dep(name = "aspect_rules_lint", version = "1.6.0")
git_override(
    module_name = "aspect_rules_lint",
    commit = "f04070cf6b91fa2a9a3c1470ff1594701f5de2fd",
    remote = "https://github.com/TroyKomodo/rules_lint.git",
)

Language(s) and/or frameworks involved: javascript

How to reproduce

https://github.com/TroyKomodo/rules_lint_issue

Any other information?

No response

[alexeagle]

I don't follow - where are the environment variables set, and how are they read?

eslint runs as a Bazel action, so you'd run bazel aquery to see how that action is spawned. If you want env vars for the whole bazel build you might need --action_env=MY_VAR[=value] or if it's just for eslint you might need a custom js_binary

[TroyKomodo]

I think the

rules_lint/lint/eslint.bzl

Lines 142 to 153 in a3e4464

	ctx.actions.run(
	inputs = _gather_inputs(ctx, srcs, file_inputs),
	outputs = [stdout, exit_code],
	executable = executable._eslint,
	arguments = [args],
	env = dict(env, **{
	"BAZEL_BINDIR": ctx.bin_dir.path,
	"JS_BINARY__EXIT_CODE_OUTPUT_FILE": exit_code.path,
	}),
	mnemonic = _MNEMONIC,
	progress_message = "Linting %{label} with ESLint",
	)

needs use_default_shell_env = True otherwise it does not respect --action_env and path variables.

[alexeagle]

Yes - but note that will rely on
https://registry.build/flag/bazel/?flag=incompatible_merge_fixed_and_default_shell_env

otherwise the env block is lost. See #112 (comment)