fix: Correct Dict type alias instantiation in attachments

- Replace Dict[str, Any]() instantiation with plain dict returns
- Update test assertions from .id to ["id"] syntax
- All 430 tests now pass

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: asachs01

py_autotask/entities/attachments.py

@@ -105,7 +105,7 @@ def upload_file(
                 result = response.json()
 
                 self.logger.info(f"Successfully uploaded attachment: {file_path.name}")
-                return Dict[str, Any](**result.get("item", result))
+                return result.get("item", result)
 
         except requests.exceptions.Timeout:
             raise AutotaskTimeoutError(f"Upload timed out for file: {file_path.name}")
@@ -172,7 +172,7 @@ def upload_from_data(
             result = response.json()
 
             self.logger.info(f"Successfully uploaded attachment from data: {filename}")
-            return Dict[str, Any](**result.get("item", result))
+            return result.get("item", result)
 
         except Exception as e:
             self.logger.error(f"Failed to upload data as {filename}: {e}")
@@ -237,7 +237,7 @@ def get_attachments_for_entity(
         }
 
         response = self.query(query)
-        return [Dict[str, Any](**item) for item in response.items]
+        return [item for item in response.items]
 
     def delete_attachment(self, attachment_id: int) -> bool:
         """
@@ -262,7 +262,7 @@ def get_attachment_info(self, attachment_id: int) -> Optional[Dict[str, Any]]:
             Attachment metadata or None if not found
         """
         data = self.get(attachment_id)
-        return Dict[str, Any](**data) if data else None
+        return data if data else None
 
     def batch_upload(
         self,

tests/test_attachments.py

@@ -91,7 +91,7 @@ def test_upload_file_success(
                 title="Test File",
             )
 
-            assert isinstance(result, AttachmentData)
+            assert isinstance(result, dict)
             mock_client.session.post.assert_called_once()
 
     @patch("py_autotask.entities.attachments.Path")
@@ -136,7 +136,7 @@ def test_upload_file_too_large(self, attachments_entity):
                         parent_type="Ticket", parent_id=67890, file_path=temp_file_path
                     )
 
-                    assert isinstance(result, AttachmentData)
+                    assert isinstance(result, dict)
         finally:
             # Clean up
             os.unlink(temp_file_path)
@@ -165,7 +165,7 @@ def test_upload_from_data_success(self, attachments_entity, mock_client):
             title="Test Data File",
         )
 
-        assert isinstance(result, AttachmentData)
+        assert isinstance(result, dict)
         mock_client.session.post.assert_called_once()
 
     def test_upload_from_data_too_large(self, attachments_entity):
@@ -187,7 +187,7 @@ def test_upload_from_data_too_large(self, attachments_entity):
                 filename="large.txt",
             )
 
-            assert isinstance(result, AttachmentData)
+            assert isinstance(result, dict)
 
     def test_download_file_success(self, attachments_entity, mock_client):
         """Test successful file download."""
@@ -228,7 +228,7 @@ def test_get_attachments_for_entity(
         result = attachments_entity.get_attachments_for_entity("Ticket", 67890)
 
         assert len(result) == 1
-        assert isinstance(result[0], AttachmentData)
+        assert isinstance(result[0], dict)
         mock_client.query.assert_called_once()
 
     def test_get_attachment_info(
@@ -239,8 +239,8 @@ def test_get_attachment_info(
 
         result = attachments_entity.get_attachment_info(12345)
 
-        assert isinstance(result, AttachmentData)
-        assert result.id == 12345
+        assert isinstance(result, dict)
+        assert result["id"] == 12345
         mock_client.get.assert_called_once()
 
     def test_delete_attachment_success(self, attachments_entity, mock_client):