ROR display restriction & Δ Axis Max auto-jump issue in Designer

[Terracotta-6]

When the ROR value exceeds 35, its display will be restricted.
When designing curves with Designer, the Max value of Δ Axis will automatically jump to 30.

Batch for Glosli - Batch 1001.csv.alog.txt

[MAKOMO]

There is a RoR Limit Filter under menu Config >> Curves, 2nd tab "Filters". This one defaults to -95F to 95F. I will update those defaults to 14F / -10C to 113F / 45C. Then in the Axis dialog you can have the RoR axis max limit be computed from the chart, however, the RoR Filter limit will always be applied. The designer did not yet respect this auto-RoR-axis-limit setting in all cases.

[Terracotta-6]

Thanks for the detailed explanation! This clears up my confusion about the RoR Limit Filter and axis setting priority. Appreciate your help!

[Terracotta-6]

Test Analyzer shows an error message. Could there be an issue with the alog data?
01-15 11:24:11 MainThread artisanlib.canvas INFO : memory used 244.4M, 3.3G (21%) available
01-15 11:24:12 MainThread artisanlib.main INFO : profile loaded: C:/Users/86776/Documents/Kaleido M1-3_25-12-20_2042.alog
01-15 11:24:22 MainThread artisanlib.main ERROR : array of sample points is empty
Traceback (most recent call last):
File "artisanlib\main.py", line 7537, in curveSimilarity
File "numpy\lib_function_base_impl.py", line 1675, in interp
ValueError: array of sample points is empty
01-15 11:24:22 MainThread artisanlib.canvas ERROR : Exception: curveSimilatrity(): array of sample points is empty
01-15 11:24:22 MainThread artisanlib.main ERROR : array of sample points is empty
Traceback (most recent call last):
File "artisanlib\main.py", line 7537, in curveSimilarity
File "numpy\lib_function_base_impl.py", line 1675, in interp
ValueError: array of sample points is empty
01-15 11:24:22 MainThread artisanlib.canvas ERROR : Exception: curveSimilatrity(): array of sample points is empty
Kaleido M1-1_25-12-20_2011.alog.txt

[MAKOMO]

Loading your file after a Factory Reset throws no exception. Thus we cannot duplicate this. The function where the exception is thrown compares foreground and background profile. If the background profile is empty it just does not execute and no error is thrown.

So we need your background profile to duplicate and fix this one. Please attach it here. Thanks!

[MAKOMO]

Not your settings file is needed, but the roast template/profile loaded into the background.

[Terracotta-6]

Another way to judge, don't laugh at me: the function name in the code is misspelled, it should be "curveSimilarity" instead of "curveSimilatrity".

[MAKOMO]

Oh, I see. I can duplicate the issue now on using starting the Analyzer using your settings. I fixed this one and the typo in the error message. Thanks for reporting!

[Terracotta-6]

The issue has been fixed in the new commit 8db289c. Thank you!

[Terracotta-6]

Looking at the Artisan source code, I spotted a few possible improvements. Just sharing my take — feel free to chime in if I’m off. Cheers!
pid_dialogs.py
2487- "Recomended" Fixed "Recommended"
4414 - string += '\n\nRecomended Mode = 0\n'
Fixed 4414 + string += '\n\nRecommended Mode = 0\n'
queue.py Function name spelling error
Fixed surpress_zero_values to suppress_zero_values

[Terracotta-6]

Again I cannot download the zip you attached 2 hours ago. It says "uploading..". Please verify what I just commited and apply your fix to the current .ts file from the repository again. Sorry for the interleaved updates.
bf742fe
artisan_zh_CN.zip

[MAKOMO]

The punctuation mark is not of a major concern. Some languages require a different ending punctuation mark in some cases then the source. Qt just marks those to let you verify. It sometimes happens that (by accident) the ending of a sentence (in source or translation) contains eg. an extra space character as it seems to be the case in your screenshot for the source term (here it seems to be an error, I will take a look and fix it). But in general this is not a big concern. Thanks for pointing this out.

Now I could download your updated translation file and will add it with my next commit, taking a look at those ending punctuation marks. Give me a moment.

[MAKOMO]

I am not a big fan of adding an sentence end punctuation mark for short single phases for warnings or short descriptions. I consider them not necessary. However, changing the end punctuation marks at this stage in the source requires adjusting them in all translations (20+!). That is a lot of work. I will adjust those you stumbled on. I see them in the Linguist.

[Terracotta-6]

The phrase ending symbols in different languages do not affect the overall effect and do not require special handling.

[MAKOMO]

Right. I update some of the sources and added your translations. I think those translations are now in an excellent condition! Thank you very much for this work and continuous reporting issues you discover.

[Terracotta-6]

Exploring the use of -1 values in Arduino TC4's error handling
Current system mechanism:

1. When communication fails, the ARDUINOTC4temperature function returns -1 directly
2. The is_proper_temp function checks temperature values and explicitly excludes -1
3. Temperature values are validated before use

Problems with this approach:

• Temperature curve suddenly drops to -1, creating data gaps
• Poor user experience - temporary communication interruptions cause error values to appear
• Doesn't match real usage scenarios where users prefer to see the last valid value

Approach 1: Save last valid values within the function
def ARDUINOTC4temperature(self, chan: str|None = None) -> tuple[float, float]:
try:
# Try to read
temp1, temp2 = self._read_temperatures_from_device()

       # If error value, use previous valid values
       if temp1 == -1 and hasattr(self, '_last_temp1'):
           temp1 = self._last_temp1
       if temp2 == -1 and hasattr(self, '_last_temp2'):
           temp2 = self._last_temp2

       # Update valid values
       if temp1 != -1:
           self._last_temp1 = temp1
       if temp2 != -1:
           self._last_temp2 = temp2

       return temp1, temp2
   except:
       # Return saved last values on exception
       t1 = getattr(self, '_last_temp1', 0)
       t2 = getattr(self, '_last_temp2', 0)
       return t1, t2

Approach 2: Optimize validation method
Keep is_proper_temp checks but handle fallback logic at higher level

Benefits of this approach:

• Avoid sudden jumps in temperature curve
• Provide smoother user experience
• Compatible with existing validation mechanisms
• Natural transition to actual readings when communication is restored

✦ In fact, industrial control system temperature monitoring typically uses similar approaches, using "last valid
value" instead of error values rather than displaying error states directly.

[Terracotta-6]

Thanks for clarifying! Artisan’s built-in global handling of -1 error values is totally solid and covers everything. As a new learner on this project, my idea was just a casual thought from my exploration—I have no intention of changing the existing mechanism at all. I’ll stick to the established workflow moving forward.

[MAKOMO]

I understand. Anyhow, please keep reporting on ideas and possible improvements. I will try to explain rationals on the current mechanisms.

[MAKOMO]

Just did commit additional tooltips (Config >> Curves, Filters). I added automatic CN translations via Google. Maybe you find the time to verify and improve those. THANKS!

[Terracotta-6]

b073929

artisan_zh_CN.zip

Linear decay average filter, applied if not recording. Resulting signal is used for RoR computation.
线性衰减平均滤波器，非录制状态下生效。滤波后的信号将用于升温速率 (RoR) 计算。

Minimal-delay low-pass filter eliminating tiny spikes, applied if not recording
低延迟低通滤波器，用于消除微小尖峰，非录制状态下生效

Removes stair-step patterns caused by duplicate readings through interpolation
通过插值消除重复读数导致的阶梯状曲线

Render curves before CHARGE and after DROP
在CHARGE之前和DROP之后渲染曲线

Removes large spikes
去除大的尖峰

[MAKOMO]

Excellent! Just added. THANKS!

[Terracotta-6]

Enter the Cup Profile information in the background and save it.
Background... Ctrl+B After loading the alog, the background does not display curves.
Switch Profiles Ctrl+F4 Switch to foreground, the Cup Profile information in alog is cleared.

Kaleido M1-_26-01-27_0625.alog.txt

[MAKOMO]

Ah ok. Now I got it. Your attached profile is empty (no recorded profile data). Thus there is no curve to be displayed. However, it links to a background profile. If you load this profile into the background, nothing is to be displayed. This is correct. If you load it into the foreground, again nothing is to be displayed for this foreground profile, however, as it is linked to a background profile, that background profile is loaded into the background and displayed. So all seems to be fine here. I cannot see anything going wrong. Do I miss something?

[Terracotta-6]

This commit c6c07ad enhances the cup profile chart functionality by adding a legend feature. It successfully
adds the legend to display both current and background cup profile data, and corrects temperature unit
conversion functions for RoR (Rate of Rise) values.

However, an interesting behavior was observed related to how cup profiles are displayed when loading .alog files
into the background versus the foreground in Artisan:

1. Files Without Roast Data: If an .alog file contains cup profile information but lacks roast curve data
   (i.e., empty timex, temp1, temp2 arrays), loading it into the background mode will not display the cup
   profile chart, even though the cup data exists in the file. This is because the display logic for the
   background chart seems to require active roast curve data to render the cup profile section.

2. Files With Roast Data: If an .alog file contains both roast curve data and cup profile information, loading
   it into the background (or foreground) will correctly display the cup profile chart with the legend
   functionality added in this commit.

3. Foreground Editing: When cup profile information is edited and saved in the foreground, the resulting file
   retains the roast curve data, so this issue does not occur when viewing or loading it later.

✦ In summary: The new legend feature in commit c6c07ad works correctly, but there's a display quirk where cup
profiles aren't visualized in the background if the loaded file lacks roast curve data, even though the cup data
itself is present. This is a display behavior rather than a data storage issue.

Kaleido M1-1_25-12-20_2011-1.zip

[MAKOMO]

So the open point seems to be 1). I don't see this issue. Here I loaded your profile, the one without curve data, but with cup data, into the background.

This first screenshot shows the Cup Profile display directly after loading that profile into the background. You see the default spider diagram as no foreground is loaded and nothing else.

This second screenshot shows the situation after ticking the "Background" flag. The cup profile of the empty loaded background profile is correctly shown.

I still don't see an issue in this logic. Cup Profile shows the spider diagram of the loaded foreground profile in blue (independent if this has curve data or not) and if a user wants to compare this one with the one of the background profile (in red), he can tick the Background flag. Of course this only works if a background profile is loaded.

[MAKOMO]

What I see is that the total sum is not fully vertical aligned in the chart. I will fix this.

[Terracotta-6]

Thank you very much for providing the detailed explanation and screenshots! Now I understand the correct logic
for cup profile display in the Artisan software.

According to your explanation, I now understand:

1. Correct display logic:
   • Cup profile data of the foreground profile is displayed in blue
   • Cup profile data of the background profile is displayed in red (via the "Background" checkbox)
   • This mechanism applies to any profile, regardless of whether it has roast curve data

✦ 2. Issue clarification:
- You pointed out that even profiles without roast curve data but with cup profile data will have their cup
information correctly displayed when loaded into the background
- The issue I previously understood (background mode not displaying profiles with only cup data) actually
does not exist