Bug: role creation makes dev database error out

[JasperSurmont]

Atlas generated a migration based on my .hcl file, creating:

CREATE ROLE rolename

The problem is, and I believe this is a bug, that when using a non-Docker dev database, every migrate comand fails because role already exists.

I know it's an easy fix to instead change the SQL migration to only create the role if it doesn't exist, but this was automatically created a while back. The only way to fix this issue (as I cannot simply make another migration 'fixing' this), was to go back in the migrations that were already applied on Production, adding the check if the role already exists.

I believe this is not the proposed way to do this.

[luantranminh]

@JasperSurmont regarding the dev database you mentioned, do you mean the database specified in the --dev-url flag? If so, is your database empty? The dev database is supposed to be fresh so Atlas can use it properly.

https://atlasgo.io/concepts/dev-database

[luantranminh]

If you still encounter the issue after using an empty one, could you provide a small, reproducible example? I will work on a fix shortly.

[JasperSurmont]

I changed my migration to only create it if not exists, so I haven't seen the issue pop up anymore. However, yes, the (GitHub) workflow was:

1. Create Postgres db
2. Run atlas migrate lint
3. If lint passes, run atlas migrate push

I believe it was in the 3rd step that this errored, I believe because the dev database was reused and in both steps 2 and 3 the migrations are ran? In that case, it probably is not a bug and rather a requirement to always start with a fresh dev database.