Support for @WithSpan ?

[wimdeblauwe-volvo]

Testing with Arconia OpenTelemetry 0.18.2, it seems that @Observed (from Micrometer) works out-of-the-box. However, @WithSpan (from OpenTelemetry) does not work.

To make it work, I had to do the following changes:

1. Add the annotations dependency to be able to add the @WithSpan annotation:

    <dependency>
      <groupId>io.opentelemetry.instrumentation</groupId>
      <artifactId>opentelemetry-instrumentation-annotations</artifactId>
    </dependency>

2. The annotations themselves do not do anything, so to make it work, I looked into the OpenTelemetry Spring Boot starter to see how it works. I added these dependencies:

    <dependency>
      <groupId>io.opentelemetry.instrumentation</groupId>
      <artifactId>opentelemetry-instrumentation-annotations-support</artifactId>
    </dependency>
    <dependency>
      <groupId>io.opentelemetry.instrumentation</groupId>
      <artifactId>opentelemetry-instrumentation-api-incubator</artifactId>
    </dependency>
    <dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-starter-aop</artifactId>
    </dependency>

And copied the 6 classes from https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/annotations into my own project.

I also had to comment out ConditionalOnEnabledInstrumentation on InstrumentationAnnotationsAutoConfiguration.

After that, the @WithSpan annotation worked, I had an extra trace showing up in Grafana.

I wonder if this is the intention, or if the framework could do more to also support @WithSpan ?

[ThomasVitale]

Thanks so much for trying out Arconia OpenTelemetry and for sharing feedback about your experience. Much appreciated!

Currently, Arconia supports the different Micrometer annotations for metrics and traces which cover more use cases (e.g. @NewSpan, @ContinueSpan...). I originally created a feature request for @WithSpan, but decided to close it until someone asked for it. That time has come, so I have re-opened the issue and I'd be happy to support the OTel Java Instrumentation annotations as well :) Here's the issue: #26