The build_circuit() function may disable the structured decomposability property?

[chenweixin107]

I am trying to load a Logical Circuit from SDD as follows:

with NamedTemporaryFile() as f:
    # export the SDD to a file
    alpha.save(f.name.encode())
    f.flush()

    # parse the SDD representation using the SDD class
    alpha_sdd = SDD.from_file(f.name)
    alpha_symbolic = alpha_sdd.build_circuit()

It's known that an SDD satisfies both structured decomposability and partitioned determinism. So, this Logical Circuit is supposed to have these properties as well.

However, when I printed out the properties of this Logical Circuit, it turned out that it does not satisfy structured decomposability.

alpha_symbolic.properties
StructuralProperties(smooth=True, decomposable=True, structured_decomposable=False, omni_compatible=False)

Meanwhile, I noticed that the build_circuit() function will trim and compress the SDD using unit propagation. So I assume these operations may damage the structure of SDD, making the resulting Logical Circuit does not possess the good properties held in SDDs.
I wonder whether my intuition is correct. Thanks!

[n28div]

Hi, thank you for noticing the issue! Can you please see if using #354 fixes your problem? It will be merged into main soon and contains some fixes for logic circuits as well.

[chenweixin107]

Hi @n28div , thanks for the prompt reply!

I have tried using your PR; however, the problem persists.

Specifically, I played with the semantic-probabilistic-layer.ipynb notebook. When I run print(alpha_symbolic.properties) , it shows:

StructuralProperties(smooth=True, decomposable=True, structured_decomposable=False, omni_compatible=False)

But since alpha_symbolic is built from an SDD, its structured_decomposable is supposed to be True.