fixup! fixup! fixup! fixup! - B PackageSettings only needs to support private ctor if the members are all static

lazy create

Author: JayBazuzi

approvaltests-util/src/main/java/org/packagesettings/PackageLevelSettings.java

@@ -50,7 +50,7 @@ private static Map<String, Settings> getSettingsFor(String packageName, HashSet<
     {
       Class<?> clazz = loadClass(packageName + "." + PACKAGE_SETTINGS);
       Field[] declaredFields = clazz.getDeclaredFields();
-      Object o = createInstance(clazz);
+      Object o = null;
       for (Field field : declaredFields)
       {
         if (Modifier.isStatic(field.getModifiers()))
@@ -59,6 +59,10 @@ private static Map<String, Settings> getSettingsFor(String packageName, HashSet<
         }
         else
         {
+          if (o == null)
+          {
+            o = createInstance(clazz);
+          }
           settings.put(field.getName(), getFieldValue(field, o));
         }
       }
@@ -88,6 +92,7 @@ private static Settings getFieldValue(Field field, Object from)
   private static Object createInstance(Class<?> clazz) throws Exception
   {
     Constructor<?> constructor = clazz.getDeclaredConstructor();
+    constructor.setAccessible(true);
     return constructor.newInstance();
   }