Skip to content

chore: compatible with reload action of parameters definition#10079

Merged
leon-ape merged 3 commits intomainfrom
support/compatible-reload-action
Mar 19, 2026
Merged

chore: compatible with reload action of parameters definition#10079
leon-ape merged 3 commits intomainfrom
support/compatible-reload-action

Conversation

@leon-ape
Copy link
Copy Markdown
Contributor

No description provided.

@leon-ape leon-ape added this to the Release 1.2.0 milestone Mar 11, 2026
@leon-ape leon-ape requested a review from kizuna-lek March 11, 2026 13:24
@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Mar 11, 2026
@apecloud-bot
Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Mar 11, 2026
@leon-ape leon-ape force-pushed the support/compatible-reload-action branch from 4cd4d68 to 39db52b Compare March 11, 2026 13:26
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 65.30612% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.61%. Comparing base (edcc808) to head (8f765ba).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../parameters/componentdrivenparameter_controller.go 60.00% 26 Missing and 12 partials ⚠️
...ontrollers/parameters/reconfigure/legacy_compat.go 51.16% 15 Missing and 6 partials ⚠️
controllers/parameters/reconfigure/sync.go 82.50% 10 Missing and 4 partials ⚠️
controllers/parameters/reconfigure_controller.go 51.85% 10 Missing and 3 partials ⚠️
pkg/kbagent/service/action_utils.go 0.00% 12 Missing and 1 partial ⚠️
pkg/parameters/config_util.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10079      +/-   ##
==========================================
+ Coverage   51.42%   51.61%   +0.19%     
==========================================
  Files         524      525       +1     
  Lines       57853    58135     +282     
==========================================
+ Hits        29749    30008     +259     
- Misses      25171    25182      +11     
- Partials     2933     2945      +12     
Flag Coverage Δ
unittests 51.61% <65.30%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape leon-ape force-pushed the support/compatible-reload-action branch 2 times, most recently from c4fcf20 to c946bcb Compare March 16, 2026 11:17
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Mar 16, 2026
@leon-ape leon-ape force-pushed the support/compatible-reload-action branch 4 times, most recently from 05da089 to df580a4 Compare March 17, 2026 02:27
@leon-ape leon-ape marked this pull request as ready for review March 17, 2026 02:28
@leon-ape leon-ape requested a review from a team as a code owner March 17, 2026 02:28
@leon-ape leon-ape force-pushed the support/compatible-reload-action branch from df580a4 to 8f765ba Compare March 17, 2026 02:55
@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 17, 2026
Copy link
Copy Markdown
Contributor

@cjc7373 cjc7373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, old cluster will invoke kbagent's reconfigure action to makes a GRPC call to config-manager.

@leon-ape
Copy link
Copy Markdown
Contributor Author

If I understand correctly, old cluster will invoke kbagent's reconfigure action to makes a GRPC call to config-manager.

Yes. For existing clusters still using legacy ParametersDefinition.reloadAction, we translate it into a reconfigure GRPCAction, and kbagent calls the in-pod legacy config-manager through that action.

This is compatibility only for existing instances; new instances are expected to use cmpd lifecycle actions directly.

@leon-ape leon-ape merged commit badbaba into main Mar 19, 2026
81 of 87 checks passed
@leon-ape leon-ape deleted the support/compatible-reload-action branch March 19, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants