Skip to content

add unit test coverage for AmberMessage envelopes #4828

Description

@aglinxinyuan

Task Summary

The five files in amber/src/main/scala/org/apache/texera/amber/engine/common/ambermessage (WorkflowMessage, WorkflowFIFOMessagePayload, DirectControlMessagePayload, RecoveryPayload) define the message envelopes that flow through the engine, but only DataFrame.equals/DataFrame.inMemSize is currently tested. Add AmberMessageEnvelopesSpec:

  • WorkflowFIFOMessage and WorkflowRecoveryMessage envelope shape
  • RecoveryPayload subtypes (UpdateRecoveryStatus, ResendOutputTo, NotifyFailedNode) carry their args; the ResendOutputTo ActorRef field is exercised via a real Pekko ActorSystem
  • WorkflowMessage.getInMemSize returns the DataFrame.inMemSize for a DataFrame payload, zero for an empty-frame, and defaults to 200L for any other WorkflowFIFOMessagePayload
  • WorkflowFIFOMessagePayload and DirectControlMessagePayload traits are implementable

Priority

P3 – Low

Task Type

  • Testing / QA

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions